Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqlalchemy 1.4 #166

Closed
cwegrzyn opened this issue Apr 2, 2021 · 3 comments
Closed

Support sqlalchemy 1.4 #166

cwegrzyn opened this issue Apr 2, 2021 · 3 comments

Comments

@cwegrzyn
Copy link
Contributor

cwegrzyn commented Apr 2, 2021

sqlalchemy 1.4 has some breaking changes. At the very least, we need to remove all uses of contextual_connect (which appears to be safe since we don't appear to use threadlocal anywhere).

Once sqlalchemy is supported in core records-mover, we should make sure that we only lift the restriction once all sqlalchemy packages have updated their own version constraints to account for their own support. (For example, sqlalchemy bigquery support does not currently support 1.4 but they have updated their constraints to reflect this)

@cwegrzyn
Copy link
Contributor Author

Looks like bigquery sqlalchemy 1.4 support is close: googleapis/python-bigquery-sqlalchemy#177

@austinweisgrau
Copy link
Contributor

bigquery compatibility has been achieved since just a few days after Chris's last message above, see: https://github.com/googleapis/python-bigquery-sqlalchemy/releases/tag/v0.8.0

@ryantimjohn
Copy link
Contributor

Completed in #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants