From 153159b0b83f6ef670d2b329e526018043cd430a Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 8 Sep 2020 20:30:18 +0000 Subject: [PATCH] Remove input.rawValue experiment I decided to not move forward with this experiment here: https://github.com/whatwg/html/issues/5257#issuecomment-607548564 Bug: 1126053 Change-Id: Ic6dd7446f14d38dc5f9f5b9538a9278c88528ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399119 Reviewed-by: Mason Freed Commit-Queue: Joey Arhar Cr-Commit-Position: refs/heads/master@{#805053} --- .../blink/renderer/core/html/forms/html_input_element.cc | 4 ---- .../blink/renderer/core/html/forms/html_input_element.h | 2 -- .../blink/renderer/core/html/forms/html_input_element.idl | 2 -- third_party/blink/renderer/core/html/forms/input_type_view.cc | 4 ---- third_party/blink/renderer/core/html/forms/input_type_view.h | 1 - .../html/forms/multiple_fields_temporal_input_type_view.cc | 4 ---- .../html/forms/multiple_fields_temporal_input_type_view.h | 2 -- .../blink/renderer/core/html/forms/text_field_input_type.cc | 4 ---- .../blink/renderer/core/html/forms/text_field_input_type.h | 2 -- .../blink/renderer/platform/runtime_enabled_features.json5 | 4 ---- .../webexposed/element-instance-property-listing-expected.txt | 1 - .../webexposed/global-interface-listing-expected.txt | 1 - 12 files changed, 31 deletions(-) diff --git a/third_party/blink/renderer/core/html/forms/html_input_element.cc b/third_party/blink/renderer/core/html/forms/html_input_element.cc index 5bf294d760f48a..c6e9bf4afdc7bf 100644 --- a/third_party/blink/renderer/core/html/forms/html_input_element.cc +++ b/third_party/blink/renderer/core/html/forms/html_input_element.cc @@ -1112,10 +1112,6 @@ String HTMLInputElement::value() const { return g_empty_string; } -String HTMLInputElement::rawValue() const { - return input_type_view_->RawValue(); -} - String HTMLInputElement::ValueOrDefaultLabel() const { String value = this->value(); if (!value.IsNull()) diff --git a/third_party/blink/renderer/core/html/forms/html_input_element.h b/third_party/blink/renderer/core/html/forms/html_input_element.h index cf78602106aeb1..5d82aa8f8fa846 100644 --- a/third_party/blink/renderer/core/html/forms/html_input_element.h +++ b/third_party/blink/renderer/core/html/forms/html_input_element.h @@ -155,8 +155,6 @@ class CORE_EXPORT HTMLInputElement bool IsValidValue(const String&) const; bool HasDirtyValue() const; - String rawValue() const; - String SanitizeValue(const String&) const; String LocalizeValue(const String&) const; diff --git a/third_party/blink/renderer/core/html/forms/html_input_element.idl b/third_party/blink/renderer/core/html/forms/html_input_element.idl index 3c153f49fd6a0e..48bb6afc2a6f6f 100644 --- a/third_party/blink/renderer/core/html/forms/html_input_element.idl +++ b/third_party/blink/renderer/core/html/forms/html_input_element.idl @@ -81,8 +81,6 @@ enum SelectionMode { "select", "start", "end", "preserve" }; readonly attribute NodeList labels; - [RuntimeEnabled=InputElementRawValue] readonly attribute DOMString rawValue; - void select(); [RaisesException, ImplementedAs=selectionStartForBinding] attribute unsigned long? selectionStart; [RaisesException, ImplementedAs=selectionEndForBinding] attribute unsigned long? selectionEnd; diff --git a/third_party/blink/renderer/core/html/forms/input_type_view.cc b/third_party/blink/renderer/core/html/forms/input_type_view.cc index 497ff6d1f4b860..e5251f53f74422 100644 --- a/third_party/blink/renderer/core/html/forms/input_type_view.cc +++ b/third_party/blink/renderer/core/html/forms/input_type_view.cc @@ -212,8 +212,4 @@ void ClickHandlingState::Trace(Visitor* visitor) const { EventDispatchHandlingState::Trace(visitor); } -String InputTypeView::RawValue() const { - return g_empty_string; -} - } // namespace blink diff --git a/third_party/blink/renderer/core/html/forms/input_type_view.h b/third_party/blink/renderer/core/html/forms/input_type_view.h index c6815772258972..ad0d26036c42a1 100644 --- a/third_party/blink/renderer/core/html/forms/input_type_view.h +++ b/third_party/blink/renderer/core/html/forms/input_type_view.h @@ -145,7 +145,6 @@ class CORE_EXPORT InputTypeView : public GarbageCollectedMixin { // Validation functions virtual bool HasBadInput() const; - virtual String RawValue() const; virtual wtf_size_t FocusedFieldIndex() const { return 0; } protected: diff --git a/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc b/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc index 36b156039174a2..31176b7fe90482 100644 --- a/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc +++ b/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc @@ -703,10 +703,6 @@ AXObject* MultipleFieldsTemporalInputTypeView::PopupRootAXObject() { return nullptr; } -String MultipleFieldsTemporalInputTypeView::RawValue() const { - return GetDateTimeEditElement()->innerText(); -} - wtf_size_t MultipleFieldsTemporalInputTypeView::FocusedFieldIndex() const { return GetDateTimeEditElement()->FocusedFieldIndex(); } diff --git a/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h b/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h index b4d3f1fb934d9c..98267a9af737eb 100644 --- a/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h +++ b/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h @@ -56,8 +56,6 @@ class MultipleFieldsTemporalInputTypeView final ~MultipleFieldsTemporalInputTypeView() override; void Trace(Visitor*) const override; - String RawValue() const override; - wtf_size_t FocusedFieldIndex() const override; private: diff --git a/third_party/blink/renderer/core/html/forms/text_field_input_type.cc b/third_party/blink/renderer/core/html/forms/text_field_input_type.cc index 361d813b358875..b0e6c4bbc0f1c1 100644 --- a/third_party/blink/renderer/core/html/forms/text_field_input_type.cc +++ b/third_party/blink/renderer/core/html/forms/text_field_input_type.cc @@ -593,8 +593,4 @@ void TextFieldInputType::SpinButtonDidReleaseMouseCapture( GetElement().DispatchFormControlChangeEvent(); } -String TextFieldInputType::RawValue() const { - return GetElement().InnerEditorElement()->innerText(); -} - } // namespace blink diff --git a/third_party/blink/renderer/core/html/forms/text_field_input_type.h b/third_party/blink/renderer/core/html/forms/text_field_input_type.h index d53045d2a2f740..645df53f88206a 100644 --- a/third_party/blink/renderer/core/html/forms/text_field_input_type.h +++ b/third_party/blink/renderer/core/html/forms/text_field_input_type.h @@ -46,8 +46,6 @@ class TextFieldInputType : public InputType, void Trace(Visitor*) const override; using InputType::GetElement; - String RawValue() const override; - protected: TextFieldInputType(HTMLInputElement&); ~TextFieldInputType() override; diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5 index e099349e283408..1775e71493a1ae 100644 --- a/third_party/blink/renderer/platform/runtime_enabled_features.json5 +++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5 @@ -938,10 +938,6 @@ name: "InertAttribute", status: "experimental", }, - { - name: "InputElementRawValue", - status: "experimental", - }, { name: "InputMultipleFieldsUI", // No plan to support complex UI for date/time INPUT types on Android. diff --git a/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt b/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt index 01e201732a2b2f..d1c8c23171f23b 100644 --- a/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt +++ b/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt @@ -732,7 +732,6 @@ html element input property name property pattern property placeholder - property rawValue property readOnly property reportValidity property required diff --git a/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt b/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt index 499842381912f1..89316b9729174a 100644 --- a/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt +++ b/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt @@ -3516,7 +3516,6 @@ interface HTMLInputElement : HTMLElement getter name getter pattern getter placeholder - getter rawValue getter readOnly getter required getter selectionDirection