Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password length check is variable but also fix coded in \bl-kernel\functions.php #1558

Open
BeJoNe opened this issue Jan 27, 2024 · 0 comments
Labels
Bug Bug in latest release version.

Comments

@BeJoNe
Copy link

BeJoNe commented Jan 27, 2024

for development reason i changed the password length in \bl-kernel\boot\variables.php to:

// Password length
define('PASSWORD_LENGTH', 3);

in \bl-kernel\functions.php
line 548 in createUser as expected:

// Password length
 if (Text::length($args['new_password']) < PASSWORD_LENGTH) {
   Alert::set($L->g('Password must be at least ' . PASSWORD_LENGTH . ' characters long'), ALERT_STATUS_FAIL);

but in line 679 its hardcoded;

  // Password length
  if (Text::length($newPassword) < 6) {
    Alert::set($L->g('Password must be at least 6 characters long'), ALERT_STATUS_FAIL);

shouldn't it be equal?

Bludit version

3.15

PHP version

8.3.2

@dignajar dignajar added the Bug Bug in latest release version. label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in latest release version.
Development

No branches or pull requests

2 participants