Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers _override #119

Open
DeliciousBounty opened this issue Feb 8, 2023 · 1 comment
Open

Servers _override #119

DeliciousBounty opened this issue Feb 8, 2023 · 1 comment

Comments

@DeliciousBounty
Copy link
Collaborator

@RazMag

The override for the flag server is broken

Few questions to make it clear:
The flag "servers-override" from the config file is intended to override any others servers that the user may have supply from the command line?
Or should the inverted, "server" supplied as an input on the command line take precedence over the configuration file?

Personally I I advise that " servers_override" from the config file will add and not override any oyhers servers and the "--server" flag will override every server including from the config file and the oas file.

OAS SERVERS

The association between the check from "engine" crate and the main crate (I mean the main function and user configuration) is a crucial element.
I'm referring to the fact that you can access the user-provided servers from the engine crate including the active check.
For the moment only the servers provided by the OAS file will always be used by the active check module.

@DeliciousBounty
Copy link
Collaborator Author

#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant