Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSHostnameMapper upgrade to C++17 #5

Open
alaric opened this issue Jan 18, 2021 · 1 comment
Open

DNSHostnameMapper upgrade to C++17 #5

alaric opened this issue Jan 18, 2021 · 1 comment

Comments

@alaric
Copy link
Contributor

alaric commented Jan 18, 2021

Now we're using C++17 for this project, the boost::shared_mutex can be converted over to a std::shared_mutex.

@adamncasey
Copy link
Contributor

We're using boost::upgrade_to_unique_lock, which as far as I can tell didn't make it into C++17. Avoiding the boost::shared_mutex would require acquiring a unique_lock at the start of the DNSHostnameMapper::prime method.

This may actually make sense, I'm getting the feeling that two parallel calls to prime may end up deadlocked. Unsure if upgrade_to_unique_lock does something special here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants