Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction signing broken with browser extension #602

Closed
radicleart opened this issue Sep 22, 2020 · 7 comments · Fixed by #674
Closed

Transaction signing broken with browser extension #602

radicleart opened this issue Sep 22, 2020 · 7 comments · Fixed by #674
Labels
bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds

Comments

@radicleart
Copy link

Screenshot 2020-09-22 at 11 27 44

Try disabling your extensions.
ERR_BLOCKED_BY_CLIENT```
@markmhendrickson markmhendrickson self-assigned this Sep 22, 2020
@markmhendrickson markmhendrickson added bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds labels Sep 22, 2020
@markmhendrickson markmhendrickson changed the title Error Opening Connect for Transaction Signing Transaction signing broken with browser extension Oct 7, 2020
@radicleart
Copy link
Author

Further info authentication (showBlockstackConnect(..)) works fine using popup. Authentication, when clicking Get Your Secret Key using the browser extension,

with versions...

    "@blockstack/connect": "^2.12.2",
    "@blockstack/stacks-transactions": "^0.6.0",
    "blockstack": "^19.3.0",

but with browser extension on yields the following stack trace;

message-bus.js:8 Uncaught ReferenceError: ServiceWorker is not defined
    at i (message-bus.js:8)
    at message-bus.js:8
i @ message-bus.js:8
(anonymous) @ message-bus.js:8
postMessage (async)
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
u @ inpage.js:1
(anonymous) @ inpage.js:1
forEach.t.<computed> @ inpage.js:1
r @ inpage.js:1
c @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
u @ inpage.js:1
(anonymous) @ inpage.js:1
forEach.t.<computed> @ inpage.js:1
r @ inpage.js:1
c @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
authenticate @ connect.cjs.development.js:266
doAuth @ connect.cjs.development.js:933
onClick @ connect.cjs.development.js:1323
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:306
executeDispatch @ react-dom.development.js:389
executeDispatchesInOrder @ react-dom.development.js:414
executeDispatchesAndRelease @ react-dom.development.js:3278
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:3287
forEachAccumulated @ react-dom.development.js:3259
runEventsInBatch @ react-dom.development.js:3304
runExtractedPluginEventsInBatch @ react-dom.development.js:3514
handleTopLevel @ react-dom.development.js:3558
batchedEventUpdates$1 @ react-dom.development.js:21871
batchedEventUpdates @ react-dom.development.js:795
dispatchEventForLegacyPluginEventSystem @ react-dom.development.js:3568
attemptToDispatchEvent @ react-dom.development.js:4267
dispatchEvent @ react-dom.development.js:4189
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
discreteUpdates$1 @ react-dom.development.js:21887
discreteUpdates @ react-dom.development.js:806
dispatchDiscreteEvent @ react-dom.development.js:4168
Show 16 more frames
11:37:35.269 dcmarket.local/:1 Uncaught (in promise) Unable to get response from Blockstack extension
Promise.then (async)
authenticate @ connect.cjs.development.js:266
doAuth @ connect.cjs.development.js:933
onClick @ connect.cjs.development.js:1323
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:306
executeDispatch @ react-dom.development.js:389
executeDispatchesInOrder @ react-dom.development.js:414
executeDispatchesAndRelease @ react-dom.development.js:3278
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:3287
forEachAccumulated @ react-dom.development.js:3259
runEventsInBatch @ react-dom.development.js:3304
runExtractedPluginEventsInBatch @ react-dom.development.js:3514
handleTopLevel @ react-dom.development.js:3558
batchedEventUpdates$1 @ react-dom.development.js:21871
batchedEventUpdates @ react-dom.development.js:795
dispatchEventForLegacyPluginEventSystem @ react-dom.development.js:3568
attemptToDispatchEvent @ react-dom.development.js:4267
dispatchEvent @ react-dom.development.js:4189
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
discreteUpdates$1 @ react-dom.development.js:21887
discreteUpdates @ react-dom.development.js:806
dispatchDiscreteEvent @ react-dom.development.js:4168
11:37:48.944 message-bus.js:8 Uncaught ReferenceError: ServiceWorker is not defined
    at i (message-bus.js:8)
    at message-bus.js:8
i @ message-bus.js:8
(anonymous) @ message-bus.js:8
postMessage (async)
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
u @ inpage.js:1
(anonymous) @ inpage.js:1
forEach.t.<computed> @ inpage.js:1
r @ inpage.js:1
c @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
u @ inpage.js:1
(anonymous) @ inpage.js:1
forEach.t.<computed> @ inpage.js:1
r @ inpage.js:1
c @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
(anonymous) @ inpage.js:1
authenticate @ connect.cjs.development.js:266
doAuth @ connect.cjs.development.js:933
onClick @ connect.cjs.development.js:1334
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:306
executeDispatch @ react-dom.development.js:389
executeDispatchesInOrder @ react-dom.development.js:414
executeDispatchesAndRelease @ react-dom.development.js:3278
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:3287
forEachAccumulated @ react-dom.development.js:3259
runEventsInBatch @ react-dom.development.js:3304
runExtractedPluginEventsInBatch @ react-dom.development.js:3514
handleTopLevel @ react-dom.development.js:3558
batchedEventUpdates$1 @ react-dom.development.js:21871
batchedEventUpdates @ react-dom.development.js:795
dispatchEventForLegacyPluginEventSystem @ react-dom.development.js:3568
attemptToDispatchEvent @ react-dom.development.js:4267
dispatchEvent @ react-dom.development.js:4189
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
discreteUpdates$1 @ react-dom.development.js:21887
discreteUpdates @ react-dom.development.js:806
dispatchDiscreteEvent @ react-dom.development.js:4168
Show 16 more frames
11:37:49.922 dcmarket.local/:1 Uncaught (in promise) Unable to get response from Blockstack extension
Promise.then (async)
authenticate @ connect.cjs.development.js:266
doAuth @ connect.cjs.development.js:933
onClick @ connect.cjs.development.js:1334
callCallback @ react-dom.development.js:188
invokeGuardedCallbackDev @ react-dom.development.js:237
invokeGuardedCallback @ react-dom.development.js:292
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:306
executeDispatch @ react-dom.development.js:389
executeDispatchesInOrder @ react-dom.development.js:414
executeDispatchesAndRelease @ react-dom.development.js:3278
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:3287
forEachAccumulated @ react-dom.development.js:3259
runEventsInBatch @ react-dom.development.js:3304
runExtractedPluginEventsInBatch @ react-dom.development.js:3514
handleTopLevel @ react-dom.development.js:3558
batchedEventUpdates$1 @ react-dom.development.js:21871
batchedEventUpdates @ react-dom.development.js:795
dispatchEventForLegacyPluginEventSystem @ react-dom.development.js:3568
attemptToDispatchEvent @ react-dom.development.js:4267
dispatchEvent @ react-dom.development.js:4189
unstable_runWithPriority @ scheduler.development.js:653
runWithPriority$1 @ react-dom.development.js:11039
discreteUpdates$1 @ react-dom.development.js:21887
discreteUpdates @ react-dom.development.js:806
dispatchDiscreteEvent @ react-dom.development.js:4168

@markmhendrickson
Copy link
Collaborator

My QA here with the Tesnet Demo is currently blocked by #642

@timstackblock
Copy link
Contributor

This is still broken

Screen Shot 2020-11-09 at 9 18 34 AM

@markmhendrickson
Copy link
Collaborator

This should be fixed now. @radicleart mind building the latest extension from source to check on your end?

@markmhendrickson
Copy link
Collaborator

@timstackblock to verify this is indeed fixed across both Firefox and Chrome

@radicleart
Copy link
Author

Just confirming this extension is now working for Loopbomb.

Tested in Chrome and Firefox.

Using @stacks versions;

"@stacks/auth": "^1.0.0-beta.7",
"@stacks/connect": "^4.1.3",
"@stacks/storage": "^1.0.0-beta.7",
"@stacks/transactions": "^1.0.0-beta.7",

@markmhendrickson
Copy link
Collaborator

I think we closed this issue prematurely since it's fixed with #674 but that PR hasn't been merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants