New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connect] Login fails on mobile #300
Comments
Thanks for the report @friedger ! I need to do some investigating. I wouldn't be surprised if cross-origin |
Not sure what you mean here. How could I check that? |
See these docs: https://github.com/blockstack/ux/tree/master/packages/connect#authoptions You can include a |
@hstove is this a matter of providing additional migration guidance rather than fixing a bug per se? |
This is coming in from a user in support who added to it above, but has not been given a response on next steps. this is impacting the coronatracker app.
|
Yes, the fix here is that you'll need to implement the usual |
So I'm still relatively new to Blockstack - are we saying that on mobile we'll have to handle Blockstack auth the "traditional" way where it opens an entirely new window etc? Or, is there a way to use both |
Still got feedback that the issue remained with Connect even in an app that explicitly called |
@SomeMoosery, yes, you'll still have to handle it the 'traditional way' on most mobile browsers. This is because mobile browsers don't support the cross-origin messaging that we do between the original app and the popup. We still have a fallback that supports redirect-based auth, like how it used to work.
@njordhov do you have an example? |
The mobile login failure is NOT explained by an app calling The CoronaTracker app uses my react-blockstack package, which sets up a BTW: Is |
Has the Connect team been able to replicate the problem of login failing on mobile? I hear login still fails on mobile when using Banter. |
Mobile login is not working even if you have |
Good catch @muneebm . I have an idea for how I could fix that. |
@friedger @muneebm @njordhov @SomeMoosery Hey guys I ran through mobile connect login on Android Chrome and it seems that the issue has been resolved. Please see the video in the link below and let me know if there is anything else needed or can we close this issue out? |
Interesting, especially since the link you followed is from an old build of the CoronaTracker app so wouldn't have been due to anything on our end. Unsure the status within Blockstack though :) |
@timstackblock xordrive: The demo app for the PR attached to this issue: |
@hstove @timstackblock sounds like its not working again |
Let me take a look |
Hi @markmhx and @hstove , Login is not working on mobile. I am attaching the authOptions of BlockSurvey below, take a look. Let me know, if anything I need to change. Thanks.
|
@BlockSurvey @muneebm We have newer docs for supporting the redirect fallback here: https://docs.blockstack.org/develop/connect/overview.html |
@hstove , Thanks for your reply. We have fallback also, attaching the code below. We observed that, if we use finished callback, redirect will not be considered. So redirect is not even happening, since below code is not getting executed. Thanks. // BS Login Module
|
I'm redirecting after my handlePendingSignIn() and run into the same issue. My bigger issue is that on mobile, the app stays in the new popup window, rather than closing and going back to the original calling window. site: video/demo:
|
Using connect library on mobile (chrome and firefox on Android) fails to handle the pending sign in.
A tab with the auth response is opened, however, the onFinish function is not called. This works on desktop e.g. for http://coronatrackerv1.s3-website-us-east-1.amazonaws.com/
Possible work around, check manually for
userSession.isPendingSignin()
and calluserSession.handlePendingSignIn()
The text was updated successfully, but these errors were encountered: