Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode error when saving file in in cache (python) #22

Open
antazoey opened this issue Sep 13, 2020 · 2 comments
Open

Unicode error when saving file in in cache (python) #22

antazoey opened this issue Sep 13, 2020 · 2 comments

Comments

@antazoey
Copy link
Contributor

antazoey commented Sep 13, 2020

Steps to reproduce

Call client.ens_address(name) in python with a successful name, such as belly.eth.

Expected behavior

Using python, when calling ens_address(), I'd expect to not get a UnicodeDecodeError almost every call.

Actual behavior

I get a UnicodeDecodeError almost every call.. Probably happens 9/10 times. It complains about a continuation byte. The line of code that fails is line 29

key = c.string_at(key).decode('utf8')

When setting a breaking point and reading the value of c.string_at(key), it looks like this:

b'ens:belly.eth:0:\xe0\xe5FX\x9b\x7f'

Which is obviously not a valid path to be saving...

System configuration

Mac OS python 3.8

Incubed version

Latest

Request

ens_address()

Incubed Configuration

SSL errors ignored

Chain

Mainnet

@antazoey antazoey changed the title Memory leak during ens_address() when setting item in cache (python) Unicode error when saving file in in cache (python) Sep 13, 2020
@antazoey
Copy link
Contributor Author

antazoey commented Sep 13, 2020

Screen Shot 2020-09-13 at 4 20 28 PM

^ Some strange bytes be saving

@antazoey
Copy link
Contributor Author

antazoey commented Sep 13, 2020

This fixes it: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant