Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CloudStorage classes to abstract file upload/download #13

Open
medvedev1088 opened this issue Mar 11, 2019 · 0 comments
Open

Create CloudStorage classes to abstract file upload/download #13

medvedev1088 opened this issue Mar 11, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@medvedev1088
Copy link
Member

medvedev1088 commented Mar 11, 2019

Right now we support S3 and GCS as cloud storage providers and file upload/download is done directly in export DAG. Instead 2 classes S3CloudStorage and GCSCloudStorage can be created with common interface to abstract upload/download logic.

As an example:

class S3CloudStorage:
     def download_file(...)
     def upload_file(...)

upload_to_gcs and download_from_gcs can be moved from export DAG to GCSCloudStorage.

@medvedev1088 medvedev1088 changed the title Create CloudStorage class to abstract file upload/download Create CloudStorage classes to abstract file upload/download Mar 11, 2019
@allenday allenday added the enhancement New feature or request label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants