Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with internally-hosted images #228

Closed
jeremydw opened this issue Aug 12, 2021 · 0 comments · Fixed by #231
Closed

Issue with internally-hosted images #228

jeremydw opened this issue Aug 12, 2021 · 0 comments · Fixed by #231
Labels
bug Something isn't working

Comments

@jeremydw
Copy link
Member

When an image URL starts with / it currently tries to load it from the editor's domain, which of course won't work.

Instead:

  • Load it from the preview server (if one exists)
  • If one doesn't exist, instead of displaying the thumbnail image just display the path to the image

image
@Zoramite Zoramite added the bug Something isn't working label Aug 12, 2021
Zoramite added a commit that referenced this issue Aug 13, 2021
@Zoramite
feat: Media preview serving path from the preview server setting.
772ac42 
Since the preview server configuration has been implemented, allow the media field to look up the preview serving url from the preview server.

fixes #228
@Zoramite Zoramite mentioned this issue Aug 13, 2021
Merged
Zoramite added a commit that referenced this issue Aug 13, 2021
@Zoramite
feat: Media preview serving path from the preview server setting. (#231)
5a00242 
Since the preview server configuration has been implemented, allow the media field to look up the preview serving url from the preview server.

fixes #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Media preview serving path from the preview server setting. blinkk/editor.dev-ui
2 participants
@Zoramite @jeremydw