Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when using invalid fields #154

Closed
jeremydw opened this issue Jul 28, 2021 · 1 comment · Fixed by #218
Closed

Improve error message when using invalid fields #154

jeremydw opened this issue Jul 28, 2021 · 1 comment · Fixed by #218
Assignees
@Zoramite
Labels
enhancement Small feature update or improvement

Comments

@jeremydw
Copy link
Member

Currently, when I make a schema change that's invalid, I get an error message like:

Unable to add field for unknown field type: undefined.

It would be better if it included the whole field configuration, so I could know which field exactly is the incorrect one. Right now, if I add 10 fields and one is incorrect, it is very hard to figure out which field is broken.

Would also probably be good to have a UI indicator in the field list indicating the broken field, but an improved error message in the Devtools would be a good start.
@adelaidemt adelaidemt added the enhancement Small feature update or improvement label Aug 3, 2021
@adelaidemt
Copy link

This task requires:

  1. change the error message to make it actionable for the developer
  2. message to show that the field is broken

@Zoramite Zoramite self-assigned this Aug 9, 2021
Zoramite added a commit that referenced this issue Aug 11, 2021
@Zoramite
feat: Message when field values are invalid for field or missing field.
44e4233 
When the editor is trying to show a field but the value is not able to be used for the field it will show a message that the value is not editable in the editor UI.

When a field type is not recognized and `Unknown` field will be used that shows a message that the field type needs to be updated.

fixes #154
fixes #94
@Zoramite Zoramite mentioned this issue Aug 11, 2021
Merged
Zoramite added a commit that referenced this issue Aug 11, 2021
@Zoramite
feat: Message when field values are invalid for field or missing fiel…
cc0cdf8 
…d. (#218)

When the editor is trying to show a field but the value is not able to be used for the field it will show a message that the value is not editable in the editor UI.

When a field type is not recognized and `Unknown` field will be used that shows a message that the field type needs to be updated.

fixes #154
fixes #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zoramite Zoramite

Labels
enhancement Small feature update or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Message when field values are invalid for field or missing field. blinkk/editor.dev-ui
4 participants
@Zoramite @jeremydw @micjamking @adelaidemt