Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panels need refresh buttons #133

Closed
jeremydw opened this issue Jul 23, 2021 · 8 comments
Closed

Panels need refresh buttons #133

jeremydw opened this issue Jul 23, 2021 · 8 comments
Assignees
Labels
design Requires UI investigation or design direction

Comments

@jeremydw
Copy link
Member

@micjamking Could we get your opinion on where to place it?

@jeremydw jeremydw changed the title Preview pane needs a refresh button Panels need refresh buttons Jul 23, 2021
@jeremydw
Copy link
Member Author

We should also have a refresh button on the left panel as well. This is useful during development when the developer may want to iterate constantly on the fields/schema setup. Currently the only way to reload the fields is to refresh the whole page.

@micjamking
Copy link

Updated mocks with refresh icons; for the left editor menu panel, I've added a new footer section which includes the theme settings and the refresh icon, for the middle editor panel, I've included the refresh icon in the "Developer Tools" section.

Screen Shot 2021-07-23 at 5 32 21 PM

@adelaidemt adelaidemt added the design Requires UI investigation or design direction label Aug 3, 2021
@jeremydw
Copy link
Member Author

NOTE: Reload button for the fields panel might be useful for non-devs too. It can serve as a way to "discard changes" and reload whatever was from GitHub.

@micjamking
Copy link

I've updated the mocks with a refresh icon in the editor panel header, near the localization and panel expansion icons:

Screen Shot 2021-08-12 at 3 52 29 PM

Note: this mock current replaces the environment links in the previous iterations (see screenshot below), however I noticed this feature is no longer included in the current version of the app. If we're still looking to support this idea in the future, then I will revise the mocks further. Please let me know.

Screen Shot 2021-08-12 at 3 53 14 PM

@Zoramite
Copy link
Member

Zoramite commented Aug 13, 2021

The links are supported in the current version, I just have not added them into the api response yet to point to the correct places:

image

I think I used the folder icon for linking to the source (ex: GitHub).

@jeremydw
Copy link
Member Author

Right-side refresh buttons look great to me. Let's add them as soon as we can since they'll be really useful during the development phase of building out Editor sites.

Regarding the link buttons - we can have a deeper discussion around those. I'm wondering if we may want to put those links inside an action menu (and therefore use text links instead). For me personally it is hard to remember what each icon means.

@Zoramite
Copy link
Member

I'm really curious how much you will end up using this as I usually find it a lot faster to switch to the browser and use Cmd + R to refresh.

How much you will use it if you have to use the mouse to navigate to refresh the settings vs refreshing the whole page. Especially when you are doing it against a local code base since it doesn't take long for the refresh to happen.

@Zoramite
Copy link
Member

Or a better way of saying that: we should have some keyboard shortcut that makes this process easier than having to click the icon for power users who don't want to refresh the entire app.

Zoramite added a commit that referenced this issue Aug 13, 2021
Instead of needing to reload the entire page to check for changes it now reloads just the individual file and clears the partials.

Also updates the states for amagaki and grow to have the `partialsOrGetPartials` style of accessing the partials to prevent the need for the UI to keep track of the initial load.

part of #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Requires UI investigation or design direction
Projects
None yet
Development

No branches or pull requests

4 participants