Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Many items cause slow rendering #4

Open
pixelass opened this issue Aug 17, 2023 · 2 comments
Open

[BUG]: Many items cause slow rendering #4

pixelass opened this issue Aug 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pixelass
Copy link
Member

pixelass commented Aug 17, 2023

Describe the bug

When I upload more that 10 images, the caption editing is noticably slower. At 20 images it is extremely laggy

Expected behavior

editing captions should be fast/immediate

Screenshots

Versions (please complete the following information):

  • Browser: [Chrome 115.0.5790.171]
  • Node.js: [v18.17.1]
  • OS: [windows 11]
  • LoRAdo [e.g. 0.1.0-alpha-3]

Additional context

as reported in #3

@pixelass pixelass added the bug Something isn't working label Aug 17, 2023
@pixelass
Copy link
Member Author

we could look into this library, but sadly there doesn't seem to be any documentation: https://tanstack.com/virtual/v3/docs/examples/react/variable

There are some examples but it is unclear if this library can handle items with images.
They have a masonry example but it is very simple and the sizeEstimation seems to be something that must be done manually (something we would have to think about)

@pixelass
Copy link
Member Author

Some improvements were made in the lastes release v0.1.0-alpha.4.
It's not perfect but a lot faster than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant