Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error importing with pandas 2.1.1 #75

Open
csteele2 opened this issue Oct 25, 2023 · 4 comments
Open

Error importing with pandas 2.1.1 #75

csteele2 opened this issue Oct 25, 2023 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@csteele2
Copy link

When attempting to import goes2go with pandas 2.1.1, I am greeted with

File timedeltas.pyx:1820, in pandas._libs.tslibs.timedeltas.Timedelta.__new__()

File timedeltas.pyx:650, in pandas._libs.tslibs.timedeltas.parse_timedelta_string()

File timedeltas.pyx:698, in pandas._libs.tslibs.timedeltas.timedelta_from_spec()

ValueError: Units 'M', 'Y' and 'y' do not represent unambiguous timedelta values and are not supported.

It looks like that was deprecated in pandas awhile ago, unless I have missed something.

@blaylockbk
Copy link
Owner

Thanks for reporting this. Looks like I need to update some code.

@blaylockbk blaylockbk self-assigned this Nov 7, 2023
@blaylockbk blaylockbk added the help wanted Extra attention is needed label Nov 7, 2023
@blaylockbk
Copy link
Owner

If you want to open a pull request, feel free. Otherwise it might take me awhile to get there.

@csteele2
Copy link
Author

It seems to only be on my apple silicon mac. Doesn't throw that fit elsewhere. I can dig a little more.

@csteele2
Copy link
Author

Okay, I still have to look into where this all occurs in your code, but definitely the config.toml file that is generated is not compliant. Changing it there seemed to fix those same errors on another system using nearesttime. According to pandas documentation (at least for 2.4.1), 'H', 'M' are not valid to use for timedeltas, and that should probably be changed to 'h' or 'hour' and 'm' or 'min' or the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants