suggestion

[panboo-leo]

Do you suggest splitting it into multiple files and adding some test code?

[blakehartshorn]

When I was working on this the first time (with a megaraid driver host) I'd just redirected the storcli command output to a text file. The second one was for the drives output. The test blocks are still hanging out in there commented out.

storcli-collector/storcli-collector.go

Lines 314 to 324 in 33e306d

	data, err := exec.Command(StorcliPath, "/cALL", "show", "all", "J").Output()
	if err != nil {
	log.Fatal(err)
	}
	/* TEST CASE - Temporarily use a text file
	data, err := os.ReadFile("controllers.json")
	if err != nil {
	log.Fatal(err)
	}
	*/

storcli-collector/storcli-collector.go

Lines 348 to 355 in 33e306d

	/* TEST CASE - Temporarily use a text file
	data, err := os.ReadFile("drives.json")
	if err != nil {
	log.Fatal(err)
	}
	*/
	data, err := exec.Command(StorcliPath, "/cALL/eALL/sALL", "show", "all", "J").Output()