Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate JWTs #1309

Open
TheTechromancer opened this issue Apr 25, 2024 · 2 comments
Open

Duplicate JWTs #1309

TheTechromancer opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request low priority Fix these last

Comments

@TheTechromancer
Copy link
Collaborator

TheTechromancer commented Apr 25, 2024

Duplicate JWTs are a problem. When you enable the web spider on a JWT-enabled website, you are likely to get two JWT events from every URL (one from excavate and one from badsecrets). That means if you spider a single website that has 1000 URLS, you will get 2000 JWTs that are effectively all the same.

I think the best way to solve this is to have a dedicated JWT event that intelligently dedupes itself by its contents, disregarding any one-time information like nonces/timestamps. This will ensure that equivalent JWTs won't be duplicated across the scan.

@TheTechromancer TheTechromancer added the bug Something isn't working label Apr 25, 2024
@TheTechromancer TheTechromancer added enhancement New feature or request and removed bug Something isn't working labels Apr 25, 2024
@aconite33 aconite33 added the low priority Fix these last label Apr 26, 2024
@liquidsec
Copy link
Collaborator

I like the idea, but i agree with the low priority tag as it would be a relatively big project for a small reward.

@TheTechromancer
Copy link
Collaborator Author

Moving JWT parsing into the event validation seems pretty small compared to most of the other reworks that are happening. Unless I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Fix these last
Projects
None yet
Development

No branches or pull requests

3 participants