-
Notifications
You must be signed in to change notification settings - Fork 41
Changes to location regexp broke previously working configs #39
Comments
This had been reported. See here: |
I did see that message and tried removing the trailing slash. But the following configuration still results in a broken config: SERVER1REVERSE_PROXY_LOCATION1: "/" Nginx reports the following error: [error] 57#57: *6 invalid port in upstream "layerindex:5000layerindex/", client: , server: _, request: "GET /layerindex/ HTTP/1.1", host: "" The change also does not work with the staticfiles patch that I submitted earlier unless I explicitly disable the resolver. |
Same here, does not work at all. Dunno how I tested this. |
Reverse proxy now adding the missing slash. |
I can confirm that the latest commit fixed the problem with the reverse proxy port parsing, but the staticfiles feature still needs to disable the resolver to work.
I tried removing the trailing slash from Location and from the alias and neither changed the behavior. If this can't be fixed, then an update to the docs should be sufficient |
Okay checking static files feature. |
Actually it is a little more complicated than that. If the resolver is enabled for LOCATION1, LOCATION2 fails regardless if the resolver is enabled or disabled. |
I was able to serve static files:
and this
If you want to use dynamic and static on the reverse proxy you should do this:
|
Prior to commit 2379d2d I had the following:
which created the following config:
After the commit the config looks like this:
The only way to make it work was to add:
SERVER1REVERSE_PROXY_DISABLE_RESOLVER1: "true"
to revert this behavior. What am I missing? Why was the default behavior changed? A notification about breaking changes would have been much appreciated.
The text was updated successfully, but these errors were encountered: