Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example folder needs clean up as there are scripts which do not follow the location guidelines. #238

Open
koshmack opened this issue Feb 7, 2023 · 3 comments

Comments

@koshmack
Copy link
Contributor

koshmack commented Feb 7, 2023

I will create clean up commit later to move scripts which are supposed to be placed under ./examples/client with instructive README

@OffBy0x01
Copy link
Collaborator

I was also thinking of doing something similar but it wasn't always easy to draw the line between the two - IIRC some of the 'examples' don't use either of the interfaces.

Perhaps we should use something like /examples/scripts for all maintained scripts, /examples/client for demo/ true examples and /examples/deprecated-hubinstance for everything else?

@koshmack
Copy link
Contributor Author

koshmack commented Feb 9, 2023

Agree with the ideas for holding the scripts which are using Client class in /examples/client and other ones which are using HubInstance class in /examples/deprecated-hubinstance. What other scripts are suggested to move to /examples/scripts? Maybe scripts which are using neither Client nor HubInstance? Besides that, it sounds like difficult to me to draw the line between 'maintained' and 'not maintained' apart form the used hub classes (Client or HubInstance).

@OffBy0x01
Copy link
Collaborator

As you say, not maintained is essentially anything using HubInstance.

I think ideally the base /examples directory should only contain the folders:

  • /examples/client

  • /examples/offline-scripts

  • /examples/deprecated-hubinstance

Everything else that is currently there can be classified under one of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants