Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL bar highlighting is lost after entering full screen mode #832

Open
7 of 9 tasks
AuRiMaS666 opened this issue Nov 29, 2023 · 2 comments
Open
7 of 9 tasks

URL bar highlighting is lost after entering full screen mode #832

AuRiMaS666 opened this issue Nov 29, 2023 · 2 comments
Labels
Class::Color Color, background, blur, etc. Class::SideEffect Unexpected side effect, undefined behavior Component::URLbar URL(address), search field or view Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Issue::Help-Wanted Extra attention is needed

Comments

@AuRiMaS666
Copy link
Sponsor

Describe the bug

After entering full screen, domain isn't highlighted properly anymore, the whole URL is in one single color. It happens the moment you hit F11, even before the UI is fully hidden away. Highlighting can only be regained by clicking inside the URL bar and then somewhere else on the page.

This isn't exactly a new issue, as I remember noticing this for quite a long time.

Expected behavior

No response

Screenshots

Before entering full screen:

before

After entering full screen:

after

OS

Windows 11

OS - Others

No response

Firefox Version

120.0

Distribution

Theme

Theme - More Info

No response

user.js setup

Default Original Lepton.

Additional context

No response
@AuRiMaS666 AuRiMaS666 added the Issue::Bug Something isn't working label Nov 29, 2023
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Color Color, background, blur, etc. Component::URLbar URL(address), search field or view Class::SideEffect Unexpected side effect, undefined behavior Issue::Help-Wanted Extra attention is needed labels Dec 2, 2023
@black7375
Copy link
Owner

I checked that the problem occurs on this line.

Firefox-UI-Fix/src/fullscreen/_overlap.scss

Line 2 in 08079e8

position: fixed !important; /* Needed for content to take up entire height */

This is a little tricky because we can't specify colors with CSS selectors.
image

As a temporary solution, you can disable userChrome.fullscreen.overlap to false.

@AuRiMaS666
Copy link
Sponsor Author

Thank you! The workaround works and doesn't sacrifice anything much for me personally with slightly different animation style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Color Color, background, blur, etc. Class::SideEffect Unexpected side effect, undefined behavior Component::URLbar URL(address), search field or view Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working Issue::Help-Wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @AuRiMaS666