Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove units logic from get_odesys #47

Open
bjodah opened this issue Feb 20, 2017 · 0 comments
Open

Remove units logic from get_odesys #47

bjodah opened this issue Feb 20, 2017 · 0 comments

Comments

@bjodah
Copy link
Owner

bjodah commented Feb 20, 2017 •
edited

The current implementation is too complicated.
Better: provide mechanism in pyodesys for early preprocessing whith dedimensionalisation,
then in extra from get_odesys provide a "dedimensionalisation" callback.

This is ongoing in the provisional API: chempy.kinetics.ode._create_odesys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjodah