Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two pytests are failing in our GitHub Action #215

Open
cclauss opened this issue Oct 10, 2022 · 3 comments
Open

Two pytests are failing in our GitHub Action #215

cclauss opened this issue Oct 10, 2022 · 3 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Oct 10, 2022

The two failing pytests in #213 should be fixed. Exception: Solving failed, conditional_maxiter reached

@bjodah
Copy link
Owner

bjodah commented Oct 10, 2022

Can you provide a direct link to the logs? I browsed some but couldn't immediately find the errors:
https://github.com/bjodah/chempy/actions

@cclauss
Copy link
Contributor Author

cclauss commented Oct 10, 2022

@bjodah
Copy link
Owner

bjodah commented Oct 10, 2022

Thanks, my guess is that the underlying solver (I think those tests are using scipy's solvers) may have changed some defaults of the solver settings. It's often tricky to get nonlinear solvers to converge, so I'm not too alarmed about these failures, but we should definitely fix them so that all tests do pass. I'm OK with putting a @xfail decorator on those tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants