Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in is_periodically_contiguous( self ): #2

Open
connorourke opened this issue Oct 19, 2017 · 1 comment
Open

bug in is_periodically_contiguous( self ): #2

connorourke opened this issue Oct 19, 2017 · 1 comment

Comments

@connorourke
Copy link

Bug in is_periodically_contiguous:

Returns True for a 2 site (and other sizes) cluster in the centre of the lattice that doesn't connect across the boundary, as the sites are both at the edges and neigbouring one another.
@bjmorgan
Copy link
Owner

bjmorgan commented Oct 19, 2017 •
edited

Good spot. Now that I can see it, it's obvious that the original method will give the wrong result for a 2-site cluster.

I've added a (failing) test for this case. bd5ffb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjmorgan @connorourke