Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual #33

Open
vahidtakro opened this issue Aug 2, 2021 · 15 comments
Open

Multilingual #33

vahidtakro opened this issue Aug 2, 2021 · 15 comments

Comments

@vahidtakro
Copy link

HIi, can I make it multilingual? I mean the markdown blog.

@bjcarlson42
Copy link
Owner

Sure. Feel free to create a pr.

@bjcarlson42
Copy link
Owner

@vahidtakro Haven't heard from you in a while. Do you still plan on implementing this?

@vahidtakro
Copy link
Author

Hello Benjamin, yes of course we can do it, I am just a very basic react learner. but we can try.

@bjcarlson42
Copy link
Owner

No worries! I'll try and help any way I can.

@vahidtakro
Copy link
Author

perfect! do you prefer to edit this project or make a new branch or my forked project?

@bjcarlson42
Copy link
Owner

you can clone this repo and then create a new branch.

@vahidtakro
Copy link
Author

Benjamin, I can not npm start the project.

@bjcarlson42
Copy link
Owner

I use yarn. So once you clone the repo run "yarn" to install the dependencies and then run "yarn dev"
to start the server.

@vahidtakro
Copy link
Author

I already multilingualed the values, about the MDX, I am not sure. Can you help multilingualing it?

@bjcarlson42
Copy link
Owner

Could you submit a pull request so I can see the code so far?

@vahidtakro
Copy link
Author

Could you submit a pull request so I can see the code so far?

I have all files on my localhost, how can I do that? should I create a repo for that? (sorry I am a new Github user)

@bjcarlson42
Copy link
Owner

You can simply commit them to GitHub just like any other project. Use the command, git push, or if you are in viscose you can use the ui. Once you do that, if you go to the code of this repo(https://github.com/bjcarlson42/benjamincarlson.io), you should see a button pop up at the top saying something like "create a pull request" Click yes and follow the steps. If you need help you can always check out githubs own learn page: https://lab.github.com

@vahidtakro
Copy link
Author

I get this error:

git push origin master
remote: Permission to bjcarlson42/benjamincarlson.io.git denied to vahidtakro.
fatal: unable to access 'https://github.com/bjcarlson42/benjamincarlson.io.git/': The requested URL returned error: 403

@bjcarlson42
Copy link
Owner

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

@vahidtakro
Copy link
Author

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

thanks,
pull request done,
I just added multilingual feature, already translated menu.
but still need to add language switcher and translate pages and MDX files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants