Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Podium does not inherited email address #107

Open
davidnewcomb opened this issue Apr 23, 2017 · 11 comments
Open

Podium does not inherited email address #107

davidnewcomb opened this issue Apr 23, 2017 · 11 comments
Assignees
Milestone

Comments

@davidnewcomb
Copy link
Contributor

I was wondering if the email address would need to come across too and I think it does.
While viewing the forums, the following message keeps (erroneously) appearing.

No e-mail address has been set for your account! Go to Profile > Account Details to add one

I think that this is a symptom of a bigger problem which is that Podium will fail to email notifications because it doesn't have an email address for an inherited user.

So I think we need another one of those new parameter thingys to cover email address as well.

@bizley
Copy link
Owner

bizley commented Apr 23, 2017

Well, yes... Now that you are speaking about this... Maybe better idea is to replace all the user single fields with one array.

@bizley bizley self-assigned this Apr 23, 2017
@bizley bizley added this to the 0.8 milestone Apr 23, 2017
@davidnewcomb
Copy link
Contributor Author

First there was password and user name, now there is email address. There may well be others and so having a container for all of the user inherited properties would simplify the surrounding code.

@elkrari
Copy link

elkrari commented Jun 11, 2017

I had the same problem/question...
You can (if you didn't yet solve it) add $newUser->email = Yii::$app->user->identity->email; to createInheritedAccount() in the User model. It will copy the email from the main App user session.

@bizley
Copy link
Owner

bizley commented Jun 11, 2017

It will be a part of user fields' array. Your solution is not good since email address field can be named differently.

davidnewcomb added a commit to davidnewcomb/yii2-podium that referenced this issue Jun 11, 2017
@elkrari
Copy link

elkrari commented Jun 11, 2017

Yes of course. I'm not giving enhancement but just a "solution" that each one can add himself to the code (and customize) to solve the problem if it's urgently needed.

@davidnewcomb
Copy link
Contributor Author

This issue was the only thing that worried be about releasing. I've added the fix to my branch along with the slug stuff, mini-forum events and now this user hack. It was enough to let me release today.
I'll have to tidy my code when version 0.8 is released but for the moment I now have everything I need.
Thanks @elkrari (and @bizley of course)

@bizley
Copy link
Owner

bizley commented Jun 11, 2017

Nice! Thanks for being patient with my lack of releases lately. Lots of other work, no time for Podium...

But API is coming up and will be sweet 💥

@davidnewcomb
Copy link
Contributor Author

I'm looking forward to the API. There is loads I wanted to do but I have to keep remembering to do my own work ;)

@elkrari
Copy link

elkrari commented Jun 11, 2017

@davidnewcomb Thrilled to help you :)
The API will be a good enhancement to Podium!
I've tried many forum modules for Yii2, and Podium (for me) is best and easiest one to install and configure. Thanks @bizley for the job!

@davidnewcomb
Copy link
Contributor Author

@bizley Is there any news on the "sweet API"? Can you checkin what you have, maybe some of us can help you complete it.

@bizley
Copy link
Owner

bizley commented Dec 12, 2017

I'm afraid there is not much now, my current job is pretty overwhelming :( But please bear with me, this will happen sooner than later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants