Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken feature after update 2023.5.0 - Unable to add user access permissions on Organization Collections #186

Open
giuliolibrando opened this issue Nov 30, 2023 · 6 comments

Comments

@giuliolibrando
Copy link

I'm unable to add user to a Collection in my Organization after the docker image upgrade. If i add a Group instead it works. The procedure gives a green pop up but the user is not added to the Collection access rules.
image
image
Tried with every user role (Owner, Administrator etc etc).

The feature worked until bitwarden 2023.5.0, i'm unable to downgrade to any older version because there's no beta tag that can go further past. I'm stuck with the latest bitwarden/self-host:beta now

I have no error in the browser console or the kubernetes container
image
image

@Adedamola-Aina
Copy link
Member

Hi @giuliolibrando

Thank you for bringing this to our observation.

I am unable to reproduce this issue, reasons been that the Bitwarden server version is on 2023.10.2 while you seem to be using an older version 2023.5.0 could you please update to the lasted version of Bitwarden and let us know if this issue persists.

We use GitHub issues as a place to track bugs and other development related issues. If your issue persists, please write us back using our “Contact support” form located on our Help Center (https://bitwarden.com/help/).

You can include a link to this issue in the message content.

Alternatively, you can also search for an answer in our help documentation (https://bitwarden.com/help/) or get help from other Bitwarden users on our community forums (https://community.bitwarden.com/c/support/).

The issue here will be closed.

Thanks!

@giuliolibrando
Copy link
Author

giuliolibrando commented Nov 30, 2023

I'm using the last version 2023.10.2!
image

The issue started from 2023.5.x, the feature worked on 2023.5.0
I tried to create a fresh installation reimporting the json license file and the json assets but the feature seems broker from the start.

@giuliolibrando
Copy link
Author

I felt hopeful after reading the changelog of the 2023.12.0 release "Bug fix for users with custom permissions import to organization".
I updated the container to the latest beta (2023.12.0) but the bug persists

@rsulzenbacher
Copy link

Same here...
When trying to update permissions on organisations.
in the UI: An unhandled server error has occurred.

in api.log:

2024-01-03 10:25:21.969 +00:00 [ERR] Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Bit.Infrastructure.EntityFramework.Repositories.DatabaseContextExtensions.UserBumpAccountRevisionDateAsync(DatabaseContext context, Guid userId) in /source/src/Infrastructure.EntityFramework/Repositories/DatabaseContextExtensions.cs:line 13
   at Bit.Infrastructure.EntityFramework.Repositories.OrganizationUserRepository.ReplaceAsync(OrganizationUser organizationUser) in /source/src/Infrastructure.EntityFramework/Repositories/OrganizationUserRepository.cs:line 425
   at Bit.Infrastructure.EntityFramework.Repositories.OrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable`1 requestedCollections) in /source/src/Infrastructure.EntityFramework/Repositories/OrganizationUserRepository.cs:line 432
   at Bit.Core.Services.OrganizationService.SaveUserAsync(OrganizationUser user, Nullable`1 savingUserId, IEnumerable`1 collections, IEnumerable`1 groups) in /source/src/Core/Services/Implementations/OrganizationService.cs:line 1328
   at Bit.Api.AdminConsole.Controllers.OrganizationUsersController.Put(String orgId, String id, OrganizationUserUpdateRequestModel model) in /source/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs:line 300
   at lambda_method35(Closure , Object )
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Logged|12_1(ControllerActionInvoker invoker)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextExceptionFilterAsync>g__Awaited|26_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)

I'm using Version 2023.12.0.
Docker on Ubuntu Linux with MariaDB as database.

@rsulzenbacher
Copy link

I found the cause of my issue.
The user account I wanted to edit the permissions wasn't fully confirmed in my organisation.
After confirmation I can edit the permissions without any problems.

@wardragon
Copy link

still there, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants