Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation on msg_server methods #219

Open
giorgionocera opened this issue Oct 6, 2022 · 0 comments
Open

Improve validation on msg_server methods #219

giorgionocera opened this issue Oct 6, 2022 · 0 comments
Assignees
Labels

Comments

@giorgionocera
Copy link
Contributor

In the nft module, inside the methods of the msg_server, we should improve the validations.

In particular, we should include validation on:

  • CreateCollection method: on data of the collection (Symbol, Name, Uri can also be empty strings, and, UpdateAuthority address can also be an invalid string). Even the ValidateBasic function does not perform these checks. Deriving from issue CreateCollection msg_server #193
  • UpdateMetadata method: on data of the collection (Name, Uri can also be empty strings, SellerFeeBasisPoints can be any positive number, and, Creators addresses can also be invalid strings). Even the ValidateBasic function does not perform these checks (only checks that SellerFeeBasisPoints is not greater than 100). Deriving from issue UpdateMetadata msg_server #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants