Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages for collection verifying nft module #213

Open
giorgionocera opened this issue Oct 2, 2022 · 4 comments
Open

Messages for collection verifying nft module #213

giorgionocera opened this issue Oct 2, 2022 · 4 comments
Labels
bug Something isn't working low-priority NFT

Comments

@giorgionocera
Copy link
Contributor

In the nft module, there is the nft/types/msgs.go file, which contains the messages.
Here there exist two messages which are unused and should be removed:

TypeMsgVerifyCollection            = "verify_collection"
TypeMsgUnverifyCollection        = "unverify_collection"

Do you agree?

@ryusmo
Copy link
Contributor

ryusmo commented Oct 3, 2022

Yes - it was available on old design.

ryusmo added a commit that referenced this issue Oct 3, 2022
@ryusmo
Copy link
Contributor

ryusmo commented Oct 3, 2022

Resolved on this commit
3febed5

Please close the issue if things are okay @giorgionocera

@giorgionocera
Copy link
Contributor Author

This is also used in CLI flags. I think we should also remove it from there.

func FlagVerifyCollection() *flag.FlagSet {
fs := flag.NewFlagSet("", flag.ContinueOnError)
fs.Uint64(FlagCollectionId, 0, "Id of the collection to verify")
fs.String(FlagNftId, "", "Id of the nft to be verififed")
return fs
}

Do you agree?

@lukfm-mms
Copy link

i'm agree

@giorgionocera giorgionocera added bug Something isn't working NFT low-priority and removed ready-for-review labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority NFT
Projects
None yet
Development

No branches or pull requests

3 participants