New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitBucketServer [skip ci] feature doesn't work for automatic triggers #111

Open

vadlit opened this issue Oct 28, 2021 · 0 comments

vadlit commented Oct 28, 2021

BitBucketServer [skip ci] feature doesn't work for automatic triggers - commit comments are always empty nevertheless I see them in my repo.

I think the reason is here: there's no commit comment in the model - https://github.com/bitrise-io/bitrise-webhooks/blob/7e68fd767996abd0bd46df56a3058479f0f557f7/service/hook/bitbucketserver/bitbucketserver.go
And it's ok, because BitbucketServer really doesn't provide this information, it provides the hash only.

But then here https://github.com/bitrise-io/bitrise-webhooks/blob/7e68fd767996abd0bd46df56a3058479f0f557f7/service/hook/endpoint.go you don't even try to take commit comment from repo, you just pass it from the model to IsSkipBuildByCommitMessage. So it doesn't work for BitBucketServer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment