Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of other trading pairs #95

Open
haisongdong-harrison opened this issue Jan 30, 2018 · 3 comments
Open

Support of other trading pairs #95

haisongdong-harrison opened this issue Jan 30, 2018 · 3 comments

Comments

@haisongdong-harrison
Copy link

Sorry that this issue is in English.
Thanks a lot for your great work!

It seems that the altcoin(e.g. ETH, BCH) markets usually have a larger price discrepancy than the BTC one. And they are highly correlated to, but less exploited than the BTC market. This r2 framework looks pretty well-rounded and I was wondering if it is possible to support other trading pairs other than just BTC/JPY.

Could there be an argument to select the pair (or several pairs) user wants to trade when starting the program? (I haven't read all the API documentation but I guess it's only about changing the symbol?)

Thank you in advance!

@PeterGrainfield
Copy link

There's no such option now, BTC/JPY only.

R2 supports three exchanges operated in Japan.
All of them provides BTC/JPY.
Other pairs are not common among exchanges.

@haisongdong-harrison
Copy link
Author

Hi @PeterGrainfield , I know there is no such option and that's why I think it could be a feature to add.
Also, at least for the altcoins I gave as examples, ETH/JPY and BCH/JPY are both available in all the major exchanges (of course the three exchanges supported by r2 are included) in Japan. They are almost as common as the BTC/JPY pair.

The reason why I think it can be added easily without too much work is that the only difference in implementation is to have a different symbol (a string) of the pair name in the request and probably add some local namespace to differentiate the data for each pair.

@bitrinjani
Copy link
Owner

Hi, currently R2 supports only BTCJPY, but yes, it is possible to enhance it to support altcoins (and other fiat currencies). Not sure when, but I'll add the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants