Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who has the best Fork ? #385

Open
nanolink opened this issue Oct 5, 2022 · 4 comments
Open

Who has the best Fork ? #385

nanolink opened this issue Oct 5, 2022 · 4 comments

Comments

@nanolink
Copy link

nanolink commented Oct 5, 2022

Hi all. It is very unfortunate that this project has been abandoned.
Is someone maintaining a good solid fork with support for both platforms (iOS & Android), which we can help with?
Right now it seems everyone is forking and cooking their own fixes.

Joining forces would be the best roadmap.

@jacobg
Copy link

jacobg commented Oct 27, 2022

I put in a fair amount of work modernizing this project:
https://github.com/jacobg/cordova-plugin-qrscanner/commits/modernize

@rolinger
Copy link

rolinger commented Feb 25, 2023

@jacobg - thanks for the work you have put into this. Two questions: is this Cordova 11 (Cordova-Android 11) compatible? And, why am I having a devil of a time trying to install it?

These are failing to find your fork:
ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner
ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner.git
ionic cordova plugin add https://github.com/jacobg/cordova-plugin-qrscanner/

The link in your github.com fork shows it as: https://github.com/jacobg/cordova-plugin-qrscanner.git - but standard adding the plugin is failing with an error of: Error: no git binary found in $PATH

I then downloaded it and tried to install locally and got an error saying "MyApp" is not in the npm registry - implying its using the package.json from my project root versus the package.json from the unpacked plugin directory. Can't make heads or tails of this one.

@jacobg
Copy link

jacobg commented Feb 26, 2023

Hi @rolinger. Yes I'm using it on Cordova Android 11 and Cordova iOS 6.2. I'm using vanilla Cordova, not Ionic.

I don't remember exactly the cli call I used originally, but it shows in package.json as follows:

"cordova-plugin-qrscanner": "github:jacobg/cordova-plugin-qrscanner#modernize"

Note it's on the modernize branch, not main branch.

So you might try running:

ionic cordova plugin add github:jacobg/cordova-plugin-qrscanner#modernize

@rolinger
Copy link

rolinger commented Feb 26, 2023

@jacobg - thanks for getting back. I recommend you and @v1934 (https://github.com/v1934/cordova-plugin-qrscanner-11) collaborate on a new qrscanner together - you two seem to be the only ones who have kept up with keeping qrscanner alive. I think a merged project, a new qrscanner, would enhance both of your individual efforts. I wouldn't mind getting in on the action too as I have a vested interest in keeping this plugin alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants