Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid usage of delete operator #246

Open
koalixCZ opened this issue May 29, 2019 · 1 comment · May be fixed by #251
Open

invalid usage of delete operator #246

koalixCZ opened this issue May 29, 2019 · 1 comment · May be fixed by #251
Labels
bug help wanted p2

Comments

@koalixCZ
Copy link

There is usage of the delete operator in the method add (browser/queue.js). This construction is not valid in the strict mode so it leads to fail when FuncUnit is imported as a ES6 module.

add = function(handler, error, context) {
  if(handler instanceof Function) {
    if(typeof error === 'object') {
      context = error;
      delete error;
    }

    error = (error && error.toString()) || 'Custom method has failed.';

Found in the npm version 3.7.0
@matthewp
Copy link
Contributor

Probably should set it to null instead

@m-mujica m-mujica linked a pull request Oct 31, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Koalix cz issue 246 bitovi/funcunit
3 participants
@matthewp @koalixCZ @chasenlehara