[bitnami/harbor] Wrong host string with sentinel enabled

[lwj5]

Name and Version

bitnami/harbor 15.0.0

What steps will reproduce the bug?

1. enabled external Redis sentinel
2. See Redis host reported in the following configmap as redis.redis:26379/mymaster:6379

Files affected:

• chartmuseum-cm-envvars.yaml
• registry-cm.yaml

Are you using any custom parameters or values?

externalRedis:
  host: redis.redis
  password: <trunc>
  sentinel:
    enabled: true
    hosts: redis.redis:26379
    masterSet: mymaster

What is the expected behavior?

If service supports sentinel, use Redis host in configmap as redis.redis:26379/mymaster

Since these services do not
chartmuseum helm/chartmuseum#179
resigtry distribution/distribution#2885

We should use Redis host in configmap as redis.redis:6379 or turn off redis for these services altogether

What do you see instead?

Cannot connect to Redis

Additional information

[RichardSufliarsky]

Try to use

externalRedis:
  host: ""

in your values.yaml.
Check also #11266 and #11354.

[lwj5]

@RichardSufliarsky do you mean port: ""? it wouldn't work

if you look at the configmaps {{ printf "%s:%s" ( include "harbor.redis.host" . ) ( include "harbor.redis.port" . ) | quote }}
The 2nd colon will always be there anyways.

Unfortunately, I do not have time to fix this chart, so I just edited the values of the affected config maps

[RichardSufliarsky]

@RichardSufliarsky do you mean port: ""? it wouldn't work

if you look at the configmaps {{ printf "%s:%s" ( include "harbor.redis.host" . ) ( include "harbor.redis.port" . ) | quote }} The 2nd colon will always be there anyways.

Unfortunately, I do not have time to fix this chart, so I just edited the values of the affected config maps

No, I mean host: "" in externalRedis, but you are right, it won't help. I looked at goharbor's helm chart and there seems to be different config for Sentinel: https://github.com/goharbor/harbor-helm/blob/9c62943736458b63cb8d8f1bd347e8cdfb34a1f9/templates/registry/registry-cm.yaml#L173
And they handle addr correctly: https://github.com/goharbor/harbor-helm/blob/9c62943736458b63cb8d8f1bd347e8cdfb34a1f9/templates/_helpers.tpl#L155

[bitnami-bot]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[lwj5]

not stale

[bitnami-bot]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[bitnami-bot]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.