Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with GPG commiting turned on #5

Open
Alxandr opened this issue Apr 20, 2016 · 3 comments
Open

Does not work with GPG commiting turned on #5

Alxandr opened this issue Apr 20, 2016 · 3 comments

Comments

@Alxandr
Copy link

Alxandr commented Apr 20, 2016

Any chance you think you can get wip to work with GPG committing turned on?

@bitjson
Copy link
Owner

bitjson commented Apr 20, 2016

Hey @Alxandr – I'd love to implement it. Would you mind spec-ing out how that should work? Would it be another setting? Should the WIP commits be signed?

Could you put together a sample list of git commands wip/naenae should run through to accommodate? Thanks!

@Alxandr
Copy link
Author

Alxandr commented Apr 21, 2016

It's not a config (though, it could be), but rather dealing with different output from git commands. As an example, look at the following:

image

If I run wip, the following happens:

image

@bitjson
Copy link
Owner

bitjson commented Apr 25, 2016

Ah, that makes sense. If you're interested in working on it, I'd love to take a pull request.

I think it might be wise to develop tests for Travis CI to run before implementing – it looks like that would require at least minor modifications to most of the code base (moving from simple execution/output to streaming input/output). Definitely would be valuable, though.

I wrote tests for the s18n CLI this weekend, and I think it would be very similar. I'll probably take a shot at implementing tests when I have some time in the next few weeks. (Though if you could submit a pull request for this feature, I would definitely prioritize it to pull in your changes!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants