Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show's naenae success when commitizen is canceled #3

Open
bitjson opened this issue Mar 7, 2016 · 2 comments
Open

Show's naenae success when commitizen is canceled #3

bitjson opened this issue Mar 7, 2016 · 2 comments
Labels

Comments

@bitjson
Copy link
Owner

bitjson commented Mar 7, 2016

Commitizen doesn't return an error code, so the "naenae completed" box is shown even when files remain staged and uncommitted.

@bitjson
Copy link
Owner Author

bitjson commented Mar 7, 2016

Pull request will have to be made to Commitizen.

@bitjson bitjson added the bug label Mar 14, 2016
@bitjson
Copy link
Owner Author

bitjson commented Mar 21, 2016

Reproduce:

npm install -g wip
wip with cz
mkdir test && cd test
git init
touch test.txt
wip
naenae

When naenae executes git-cz, if the commit is canceled or fails, no error code is returned. This causes naenae to return a success message when it should warn the user that changes are still staged and waiting for commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant