Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker result does not match sync result #305

Closed
ArnyminerZ opened this issue Apr 30, 2024 · 0 comments · Fixed by #323
Closed

Worker result does not match sync result #305

ArnyminerZ opened this issue Apr 30, 2024 · 0 comments · Fixed by #323
Assignees
@ArnyminerZ
Labels
enhancement New feature or request

Comments

@ArnyminerZ
Copy link
Member

Right now, we are always returning Result.success() in BaseSyncWorker, even if ProcessEventsTask fails. I think there should be proper error results.
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Apr 30, 2024
@ArnyminerZ ArnyminerZ self-assigned this May 8, 2024
@ArnyminerZ ArnyminerZ linked a pull request May 8, 2024 that will close this issue
Task result is based on sync status #323
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Task result is based on sync status bitfireAT/icsx5
1 participant
@ArnyminerZ