Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditCalendarActvivity: Switch to compose state and kotlin flows #319

Closed
2 tasks done
sunkup opened this issue May 7, 2024 · 0 comments · Fixed by #320
Closed
2 tasks done

EditCalendarActvivity: Switch to compose state and kotlin flows #319

sunkup opened this issue May 7, 2024 · 0 comments · Fixed by #320
Assignees
@sunkup
Milestone
2.2.3

Comments

@sunkup
Copy link
Member

sunkup commented May 7, 2024 •
edited

Switch to compose state and kotlin flows

  • move composables inside an activity to their own file using only a "screen" composable in the activity
  • the "screen" composable should try to
    • only pass primitive types to its child composable(s)
    • handle view model creation (if possible)

@sunkup this PR is getting quite big, I think we should review it now, and then migrate the remaining activity (should only be EditCalendarActivity I think).

Originally posted by @ArnyminerZ in #318 (comment)
@sunkup sunkup self-assigned this May 7, 2024
@sunkup sunkup added this to the 2.2.3 milestone May 7, 2024
@sunkup sunkup linked a pull request May 7, 2024 that will close this issue
EditCalendarActvivity: Switch to compose state and kotlin flows #320
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunkup sunkup

Labels
None yet
Projects
None yet
Milestone
2.2.3
Development

Successfully merging a pull request may close this issue.

EditCalendarActvivity: Switch to compose state and kotlin flows bitfireAT/icsx5
1 participant
@sunkup