Task result is based on sync status #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Right now, we are always returning
Result.success()
inBaseSyncWorker
, even ifProcessEventsTask
fails. There should be proper error results.Short description
Added a return type to
ProcessEventsTask.sync
, if the synchronization is successful (exception
is null) returnstrue
, otherwise returnsfalse
.Then, the result is received by
BaseSyncWorker
, which then if any of the subscriptions returns false while synchronizing, outputsResult.failure
, otherwiseResult.success
.Tests added:
The result is expected to be a failure because even though the first subscription is synchronized correctly, the second one fails.
Checklist