Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing sync interval adds new periodic workers, not updating or removing the existing one #295

Open
sunkup opened this issue Apr 18, 2024 · 0 comments
Labels
question Further information is requested

Comments

@sunkup
Copy link
Member

sunkup commented Apr 18, 2024

Changing sync interval adds new periodic workers, not updating or removing the existing one.

Reproduce:

  1. Add subscription
  2. change the sync interval
  3. See the PeriodicSyncWorkers pile up in the Background Task Inspector

image

Might be due to 2c05b63 , but I don't think so, since ExistingPeriodicWorkPolicy#UPDATE should handle this accordingly?

One might think the old work is stopped or cancelled once it attempts to run, but that does not seem to be the case ... Only after setting it to manually once and then to some timer interval will the periodic sync workers get removed.

@ArnyminerZ Can you try reproducing this as well?

We might need to switch back #REPLACE or rather #CANCEL_AND_REENQUEUE since that seems to be the new name for REPLACE.

@sunkup sunkup added the question Further information is requested label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant