Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting legacy external storage #177

Open
ArnyminerZ opened this issue Aug 23, 2023 · 0 comments
Open

Requesting legacy external storage #177

ArnyminerZ opened this issue Aug 23, 2023 · 0 comments
Labels
question Further information is requested refactoring Quality improvement of existing functions
Milestone

Comments

@ArnyminerZ
Copy link
Member

I've just realized that we are requesting legacy storage in manifest

android:requestLegacyExternalStorage="true"

is there any reason for this? I can only think about ICS file importing, but we are using contracts and persisting uri permission

private val pickFile = registerForActivityResult(ActivityResultContracts.OpenDocument()) { uri: Uri? ->
if (uri != null) {
// keep the picked file accessible after the first sync and reboots
requireActivity().contentResolver.takePersistableUriPermission(uri, Intent.FLAG_GRANT_READ_URI_PERMISSION)
binding.url.editText?.setText(uri.toString())
}
}

So I don't think this is necessary anymore. @rfc2822

@ArnyminerZ ArnyminerZ added the question Further information is requested label Aug 23, 2023
@sunkup sunkup modified the milestones: 2.2.3, 2.2.2 Apr 11, 2024
@sunkup sunkup added the refactoring Quality improvement of existing functions label Apr 22, 2024
@sunkup sunkup modified the milestones: 2.2.2, 2.2.3 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested refactoring Quality improvement of existing functions
Projects
None yet
Development

No branches or pull requests

2 participants