Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COMMENT for tasks #127

Open
5 tasks done
rfc2822 opened this issue Jan 16, 2024 · 5 comments · May be fixed by #152
Open
5 tasks done

Support COMMENT for tasks #127

rfc2822 opened this issue Jan 16, 2024 · 5 comments · May be fixed by #152
Assignees
Labels
enhancement New feature or request

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jan 16, 2024

We could support COMMENT with the Comment field for TasksOrg-compatible tasks:

interface Comment extends PropertyColumns
{
/**
* The mime-type of this property.
*/
String CONTENT_ITEM_TYPE = ContentResolver.CURSOR_ITEM_BASE_TYPE + "/comment";
/**
* Comment text.
* <p>
* Value: String
* </p>
*/
String COMMENT = DATA0;
/**
* Language code of the comment as defined in <a href="https://tools.ietf.org/html/rfc5646">RFC5646</a> or <code>null</code>.
* <p>
* Value: String
* </p>
*/
String LANGUAGE = DATA1;
}

  • Add a comment field to Task.
  • Task should be able to read the COMMENT property into the comment field
  • Task should be able to generate the COMMENT property from the comment field
  • DmfsTask: generate COMMENT data row (probably with language null) from Task.comment field
  • DmfsTask: process COMMENT data row and fill Task.comment field from it
@rfc2822 rfc2822 added the enhancement New feature or request label Jan 16, 2024
@rfc2822
Copy link
Member Author

rfc2822 commented Feb 17, 2024

I hope this is even supported by tasks.org… @sunkup interested in giving it a try?

@abaker
Copy link
Contributor

abaker commented Feb 18, 2024

Tasks.org doesn't try to sync comments yet, but I'd like to

@rfc2822
Copy link
Member Author

rfc2822 commented Feb 18, 2024

Tasks.org doesn't try to sync comments yet, but I'd like to

But we can already create the data row, right?

@sunkup
Copy link
Member

sunkup commented Feb 19, 2024

@sunkup interested in giving it a try?

Sure, I wonder which servers support the COMMENT field already though? Seems like nextcloud (tasks) does not ?

@rfc2822
Copy link
Member Author

rfc2822 commented Feb 19, 2024

Sure, I wonder which servers support the COMMENT field already though? Seems like nextcloud (tasks) does not ?

When more clients support it, I guess other clients have a better chance of adopting it. As far as I know, jtx Board also supports it.

@sunkup sunkup linked a pull request May 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants