Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Rename account" should use outlined text field #785

Closed
2 tasks done
mbiebl opened this issue May 8, 2024 · 4 comments
Closed
2 tasks done

"Rename account" should use outlined text field #785

mbiebl opened this issue May 8, 2024 · 4 comments
Assignees
@devvv4ever @ArnyminerZ
Labels
bug Something isn't working

Comments

@mbiebl
Copy link
Contributor

mbiebl commented May 8, 2024

Problem scope

  • I'm sure that this is a DAVx⁵ problem.

App version

  • I'm using the latest available DAVx⁵ version.

Android version and device/firmware type

not relevant

Steps to reproduce

Create an account then use the "Rename account" menu option.
The upcoming dialog does not use an outlined text field.

Screenshot_20240508_150143

This is inconsistent as all other forms use outlined text fields

Expected result

Use an outlined text field in rename account dialog

Further info

No response
@mbiebl mbiebl added the bug Something isn't working label May 8, 2024
@ArnyminerZ ArnyminerZ self-assigned this May 8, 2024
@ArnyminerZ ArnyminerZ linked a pull request May 8, 2024 that will close this issue
"Rename account" should use outlined text field #786
Closed
4 tasks
@rfc2822
Copy link
Member

rfc2822 commented May 9, 2024 •
edited

Hm I actually decided to use the filled text field for that screen because it is the only text field, and is important for the (only) action. See https://m3.material.io/components/text-fields/guidelines

As with the buttons, where outlined buttons are used for less important actions and the filled button is used for important actions/the default action.

Is it that clear that this field should be outlined?

What do you think @devvv4ever ?

@ArnyminerZ
Copy link
Member

Is it that clear that this field should be outlined?

No, I think you are right.

And if I'm not wrong, it's consistent amongst all dialogs, so I'd say just stick with what we have.

@mbiebl
Copy link
Contributor Author

mbiebl commented May 14, 2024 

$ grep TextField app/src/ -Rw
app/src/main/kotlin/at/bitfire/davdroid/ui/account/RenameAccountDialog.kt:import androidx.compose.material3.TextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/RenameAccountDialog.kt:            TextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/InputDialogs.kt:import androidx.compose.material.TextField
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/InputDialogs.kt:                TextField(

vs

$ grep OutlinedTextField app/src/ -Rw
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateCalendarScreen.kt:                        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/HomeSetSelection.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/HomeSetSelection.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/account/CreateAddressBookScreen.kt:                    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/PasswordTextField.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/composable/PasswordTextField.kt:    OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AccountDetailsPage.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AccountDetailsPage.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/UrlLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/GoogleLogin.kt:        OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLogin.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/EmailLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/EmailLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/AdvancedLogin.kt:            OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:import androidx.compose.material3.OutlinedTextField
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(
app/src/main/kotlin/at/bitfire/davdroid/ui/webdav/AddWebdavMountScreen.kt:                OutlinedTextField(

@devvv4ever
Copy link
Member

It is debatable according to the M3 guidelines. Personally I prefer the filled versions of text fields like the one at the moment. But as we more or less use only outlined ones right now across the other app parts we should use the outlined version there too. We might want to consider using the other ones in the future ;-)

@rfc2822 rfc2822 closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devvv4ever devvv4ever

@ArnyminerZ ArnyminerZ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Rename account" should use outlined text field bitfireAT/davx5-ose
4 participants
@rfc2822 @devvv4ever @mbiebl @ArnyminerZ