Fix setup through nextcloud app (intent) not working #782
Conversation
There was a problem hiding this comment.
We could use the initial data approach here too:
- pass
initialLoginType&initialloginInfoto theLoginScreen LoginScreeninjects/creates the model with the initial data in the constructor
Then we could get rid of the if (savedInstanceState == null) and have better separation of concerns (no direct model access from outside).
While it would have been possible (and shorter in code) I have added an extra startPage parameter as well. The alternative is to infer the starting page from the login type inside the model, which is shorter, but less flexible. I can change that back if you prefer :) The advantage would be that future intents could start the correct login page more easily. |
rfc2822
force-pushed
the
773-setup-through-the-nextcloud-app-intent-not-working
branch
from
2f75db0
to
f4e2dd4
Compare
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/LoginActivity.kt
Outdated
Show resolved
Hide resolved
sunkup
force-pushed
the
773-setup-through-the-nextcloud-app-intent-not-working
branch
from
f4e2dd4
to
488642a
Compare
rfc2822
force-pushed
the
773-setup-through-the-nextcloud-app-intent-not-working
branch
from
161a7be
to
8b81a02
Compare
- Use boolean to decide on skipping startPage - Move login type selection logic to login types provider
rfc2822
force-pushed
the
773-setup-through-the-nextcloud-app-intent-not-working
branch
from
8b81a02
to
2f9fdee
Compare
rfc2822
deleted the
773-setup-through-the-nextcloud-app-intent-not-working
branch
Purpose
The nextcloud login/setup flow could not be started via intent. This fixes it.
Short description
LoginActivity:
intentToInitialLoginType()to determine login type from intent.selectLoginType()to change the login type accordinglyLoginScreenModel:
selectLoginType()to also update the ui state of the login details page. Previously it only updated the ui state of the login type page.See also: Creation of intent in nextcloud app.
Testing
Intent for testing:
Checklist