Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite BatteryOptimizationsPage to M3 #741

Closed
Tracked by #691
rfc2822 opened this issue Apr 21, 2024 · 0 comments · Fixed by #747
Closed
Tracked by #691

Rewrite BatteryOptimizationsPage to M3 #741

rfc2822 opened this issue Apr 21, 2024 · 0 comments · Fixed by #747
Assignees
@ArnyminerZ
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Apr 21, 2024 •
edited

(See #691)

I think we can change some minor things during the rewrite:

  • Use shouldBeExempted by mutableStateOf() private set for the properties we define ourselves in the model and keep the Flows for the properties from SettingsManager.
  • Is checkBatteryOptimizations even called when the model is created?
@rfc2822 rfc2822 mentioned this issue Apr 21, 2024
Closed
12 tasks
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Apr 21, 2024
@ArnyminerZ ArnyminerZ linked a pull request Apr 24, 2024 that will close this issue
Rewrite BatteryOptimizationsPage to M3 #747
Merged
4 tasks
@rfc2822 rfc2822 mentioned this issue Apr 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite BatteryOptimizationsPage to M3 bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ