Rewrite BatteryOptimizationsPage to M3 #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
requested changes
Apr 30, 2024
There was a problem hiding this comment.
We want the activity - in this case the IntroPage to be as clean as possible. Hence we should move everything we can out into their own respective files.
In the viewModel we started to use an immutable UiState data class to hold the viewmodel state. Following the guideline and for consistency we should do that everywhere.
Looks good otherwise tho :)
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsPage.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
|
Should be ready :) |
sunkup
requested changes
May 1, 2024
rfc2822
force-pushed
the
main-ose
branch
6 times, most recently
from
1ae5eb5
to
b15cb80
Compare
rfc2822
force-pushed
the
main-ose
branch
11 times, most recently
from
47ef18b
to
39f8f2e
Compare
I'm working on it |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
approved these changes
May 6, 2024
|
Please rebase to main-ose (better DI) |
# Conflicts: # app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsPage.kt
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
sunkup
approved these changes
May 13, 2024
rfc2822
reviewed
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.
See also: Writing A Great Pull Request Description
Purpose
Update design of the battery optimizations intro page so that it uses M3.
Also updates the architecture of the activity-viewmodel-composables relationship so that it follows best practices as discussed internally, and as recommended by Google.
Short description
MaterialTheme.typography.body1::MaterialTheme.typography.bodyLargeMaterialTheme.typography.body2::MaterialTheme.typography.bodyMediumMaterialTheme.typography.h6::MaterialTheme.typography.labelLarge{}by default so that it's not required in preview.Checklist