AccountSettingsActivity: make canAccessWifiSsid live-capable #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfc2822
force-pushed
the
728-accountsettingsactivity-make-canaccesswifissid-live-capable
branch
from
fdeaa7d
to
9989106
Compare
rfc2822
requested changes
Apr 19, 2024
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/util/PermissionUtils.kt
Outdated
Show resolved
Hide resolved
rfc2822
force-pushed
the
main-ose
branch
17 times, most recently
from
47ef18b
to
39f8f2e
Compare
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
rfc2822
force-pushed
the
728-accountsettingsactivity-make-canaccesswifissid-live-capable
branch
from
e7ec996
to
65f2665
Compare
rfc2822
approved these changes
May 11, 2024
There was a problem hiding this comment.
I have changed a few things:
- use map & collect for the flow instead of just defining a
MutableLiveFlow(you don't emit outside a flow normally and it mixes hot/cold flows without explicitly making them hot) - only one
iffor Android 9 - combine state with
derivedStateOf(see Talk)
rfc2822
deleted the
728-accountsettingsactivity-make-canaccesswifissid-live-capable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canAccessWifiSsidLiveand replaced usage inAccountSettingsActivity.