Log last sync time per collection service and URL #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfc2822
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Didn't think that this was so complicated. The core problem is that there's yet no connection between the database (where the last sync shall be stored) and the content providers.
The suggested solution would work, but requires redundant code (like determining the service type from the authority) that looks not to be on the right place. Maybe we could pass the collection ID or at least service type from the Syncer, but it would require changes there.
I'll think about alternatives… really hard.
app/src/main/kotlin/at/bitfire/davdroid/syncadapter/SyncManager.kt
Outdated
Show resolved
Hide resolved
rfc2822
force-pushed
the
main-ose
branch
4 times, most recently
from
fbfee56
to
dd08415
Compare
rfc2822
force-pushed
the
699-last-synced-timestamp-is-only-applied-to-one-resource-if-there-are-multiple-collections-with-the-same-path
branch
from
d7e5906
to
23840ad
Compare
rfc2822
requested changes
Apr 19, 2024
app/src/main/kotlin/at/bitfire/davdroid/syncadapter/SyncManager.kt
Outdated
Show resolved
Hide resolved
rfc2822
force-pushed
the
main-ose
branch
17 times, most recently
from
47ef18b
to
39f8f2e
Compare
sunkup
force-pushed
the
699-last-synced-timestamp-is-only-applied-to-one-resource-if-there-are-multiple-collections-with-the-same-path
branch
from
23840ad
to
deff325
Compare
rfc2822
approved these changes
May 14, 2024
rfc2822
deleted the
699-last-synced-timestamp-is-only-applied-to-one-resource-if-there-are-multiple-collections-with-the-same-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not super pretty, but since the SyncManager itself might be rewritten at some point - I think this should do?