Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chain] It should be easy to get the transaction in canonical order #1333

Open
LLFourn opened this issue Feb 9, 2024 · 1 comment
Open
Labels
discussion There's still a discussion ongoing module-blockchain module-wallet
Milestone

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Feb 9, 2024

So as ordered by most recent to oldest vise versa

What do we mean by this?

  1. We could mean that an tx that was confirmed earlier. But what if it was broadcast earlier? Do we want transactions switching order.
  2. We could introduce the concept of first_seen which stores the first time you see the tx. Ordered by first_seen and tiebroken by confirmation height should give a nice consistent list of transactions that doesn't switch order too much. Note this wouldn't change ChangeSet behavior at all since we already have last_seen.
  3. Do transactions that are non-canonical belong in a list? e.g. transactions that were RBF'd.
@notmandatory
Copy link
Member

Can we move this to a post-1.0 milestone? it looks like a feature that can be added with a new function without breaking any of the existing apis.

@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha, 1.1.0 Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion There's still a discussion ongoing module-blockchain module-wallet
Projects
Status: Todo
Development

No branches or pull requests

3 participants