Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename bdk crate to bdk_wallet #1305

Closed
LLFourn opened this issue Jan 31, 2024 · 3 comments · Fixed by #1326
Closed

Rename bdk crate to bdk_wallet #1305

LLFourn opened this issue Jan 31, 2024 · 3 comments · Fixed by #1326
Assignees
@notmandatory
Labels
api A breaking API change module-wallet
Milestone
1.0.0-alpha

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Jan 31, 2024

All it has in it is a Wallet and the README says:

The bdk crate provides the Wallet type which is a simple, high-level
interface built from the low-level components of [bdk_chain].

It should probably just be called bdk_wallet
@evanlinjin
Copy link
Member

Thanks for creating a ticket. Everyone was thinking this for a long while.

@notmandatory notmandatory added this to the 1.0.0-alpha milestone Feb 6, 2024
@notmandatory
Copy link
Member

I put this on the project board, I think we should do it after #1203 and #1101 are merged. But should grab the bdk_wallet account in crates.io ASAP.

@notmandatory notmandatory mentioned this issue Feb 6, 2024
Merged
3 tasks
@thunderbiscuit
Copy link
Contributor

Feels right to me as well. It makes it explicit that the wallet is one of the crates the bdk project supports without giving it a special status (in that sense the simple bdk name was more confusing than anything given the 6 new crates).

@notmandatory notmandatory self-assigned this Feb 6, 2024
@notmandatory notmandatory added the api A breaking API change label Feb 6, 2024
@storopoli storopoli mentioned this issue Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notmandatory notmandatory

Labels
api A breaking API change module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

chore: rename bdk crate to bdk_wallet notmandatory/bdk
4 participants
@LLFourn @notmandatory @evanlinjin @thunderbiscuit