{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":235668568,"defaultBranch":"master","name":"bdk","ownerLogin":"bitcoindevkit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-01-22T21:16:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/62867074?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716505045.0","currentOid":""},"activityList":{"items":[{"before":"a2d940132d1e86d3dadae2c4001d4c9eb894b74c","after":"4a8452f9b8f8128affbb60665016fedb48f07cd6","ref":"refs/heads/master","pushedAt":"2024-05-23T22:38:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1450: Bump bdk version to 1.0.0-alpha.12\n\n108061dddbba99f03d7416a673135211ef94043b Bump bdk version to 1.0.0-alpha.12 (Steve Myers)\n\nPull request description:\n\n ### Description\n\n fixes #1449\n\n bdk_chain to 0.15.0\n bdk_bitcoind_rpc to 0.11.0\n bdk_electrum to 0.14.0\n bdk_esplora to 0.14.0\n bdk_persist to 0.3.0\n bdk_file_store to 0.12.0\n bdk_sqlite keep at 0.1.0\n bdk_testenv to 0.5.0\n bdk_hwi to 0.1.0\n bdk_wallet to 1.0.0-alpha.12\n\n ### Notes to the reviewers\n\n I also (hopefully) fixed the `bdk_hwi` crate so it can be published.\n\nACKs for top commit:\n ValuedMammal:\n ACK 108061dddbba99f03d7416a673135211ef94043b\n storopoli:\n ACK 108061dddbba99f03d7416a673135211ef94043b\n\nTree-SHA512: 2a80c51e254ca011b8e9bb72ad3d720dd8d09a3142e85cf230ffffad747257d91c45950cce64b049bab91f21c70c622f14d46def24ea78459497b42472a1fe48","shortMessageHtmlLink":"Merge #1450: Bump bdk version to 1.0.0-alpha.12"}},{"before":"2a055de555bc0424ba1b23c8007c46b0cc6a1cc4","after":"a2d940132d1e86d3dadae2c4001d4c9eb894b74c","ref":"refs/heads/master","pushedAt":"2024-05-23T15:19:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1393: fix(export): add tr descriptor\n\n1b7c6df569a0ff9324bbda1f066938490109481d fix(export): add tr descriptor (rustaceanrob)\n\nPull request description:\n\n ### Description\n\n Resolves #860 by adding export of taproot descriptors\n\n ### Notes to the reviewers\n\n Allows export as Core accepts taproot.\n\n ### Changelog notice\n\n - Export taproot descriptors\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [ ] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [ ] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n notmandatory:\n ACK 1b7c6df569a0ff9324bbda1f066938490109481d\n\nTree-SHA512: 80bee93a1ec531717e79a5e7a91e840532ae4d3daf677a207bc53162c69410e47db4893024b3eccfd848f1628062e7c49f0e92ebeb7230e2ebb9b47eb84b9e56","shortMessageHtmlLink":"Merge #1393: fix(export): add tr descriptor"}},{"before":"2eea0f4e906c9f943a0ed98153edd6214054b586","after":"2a055de555bc0424ba1b23c8007c46b0cc6a1cc4","ref":"refs/heads/master","pushedAt":"2024-05-23T15:08:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1386: Remove TxBuilder allow_shrinking() and unneeded context param\n\n096b8ef781b21e7da690b9ca2e4b326880d6ac0b fix(wallet): remove TxBuilder::allow_shrinking function and TxBuilderContext (Steve Myers)\n\nPull request description:\n\n ### Description\n\n Remove wallet::TxBuilder::allow_shrinking() and unneeded TxBuilder context param.\n\n Fixes #1374\n\n ### Notes to the reviewers\n\n The allow_shrinking function was the only one using the TxBuilder FeeBump context and it's useful to have CreateTx context functions available for building FeeBump transactions, see updated tests.\n\n ### Changelog notice\n\n Changed\n\n - Removed TxBuilder::allow_shrinking() function.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### Bugfixes:\n\n * [x] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [x] I'm linking the issue being fixed by this PR\n\nTop commit has no ACKs.\n\nTree-SHA512: f4f05ce4cfaced9e61eebc0ebfe77a299fae13df4459fc26c90657297a1347a5d16f22b4e1c8b9b10458cfec80ca3b5d698eee11c7a560fd83f94a1ac7101a86","shortMessageHtmlLink":"Merge #1386: Remove TxBuilder allow_shrinking() and unneeded context …"}},{"before":"2f059a1588ee3159992249c2c04e3a17fe128be3","after":"2eea0f4e906c9f943a0ed98153edd6214054b586","ref":"refs/heads/master","pushedAt":"2024-05-23T14:34:38.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1128: feat: add bdk_sqlite crate implementing PersistBackend\n\n475c5024ecc5d288f35fabb8fab2b62dbf67653b feat(sqlite): add bdk_sqlite crate implementing PersistBackend backed by a SQLite database (Steve Myers)\nb8aa76cd050bc3c2eac776ecbd9b4e2ab3e2590e feat(wallet): use the new `CombinedChangeSet` of `bdk_persist` (志宇)\n0958ff56b20c1325a7da5d5f21e7ac836c601f1f feat(persist): introduce `CombinedChangeSet` (志宇)\n54942a902d3203ee59731f35d2a1c402ac626878 ci: bump build_docs rust version to nightly-2024-05-12 (Steve Myers)\nd975a48e7c519a703441e74058321021957b177f docs: update README MSRV pinning to match CI (Steve Myers)\n\nPull request description:\n\n ### Description\n\n Add \"bdk_sqlite_store\" crate implementing `PersistBackend` backed by a SQLite database.\n\n ### Notes to the reviewers\n\n In addition to adding a SQLite based `PersistenceBackend` this PR also:\n\n * add `CombinedChangeSet` in `bdk_persist` and update `wallet` crate to use it.\n * updates the `wallet/tests` to also use this new sqlite store crate.\n * updates `example-crates/wallet_esplora_async` to use this new sqlite store crate.\n * fixes out of date README instructions for MSRV.\n * bumps the ci `build_docs` job to rust `nightly-2024-05-12`.\n\n ### Changelog notice\n\n Changed\n\n - Update Wallet to use CombinedChangeSet for persistence.\n\n Added\n\n - Add CombinedChangeSet in bdk_persist crate.\n - Add bdk_sqlite crate implementing SQLite based PersistenceBackend storage for CombinedChangeSet.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n evanlinjin:\n ACK 475c5024ecc5d288f35fabb8fab2b62dbf67653b\n\nTree-SHA512: 72565127994fbfff34d7359e1d36d6f13e552995bb7ea61dd38ba5329b0d15e500fa106214a83fd870f1017dc659ff1bb8fc71bc6aad0a793730ec7f23179d8c","shortMessageHtmlLink":"Merge #1128: feat: add bdk_sqlite crate implementing PersistBackend"}},{"before":"7607b4928321d83af96236ec666408ce03e7de70","after":"2f059a1588ee3159992249c2c04e3a17fe128be3","ref":"refs/heads/master","pushedAt":"2024-05-15T12:35:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1443: fix(electrum): Fix `fetch_prev_txout`\n\naf15ebba94f6d96a4d266fbbdee7c49150f80b96 fix(electrum): Fix `fetch_prev_txout` (valued mammal)\n\nPull request description:\n\n Previously we inserted every `TxOut` of a previous tx at the same outpoint, which is incorrect because an outpoint only points to a single `TxOut`. Now just get the `TxOut` corresponding to the txin prevout and insert it with its outpoint.\n\n ### Notes to the reviewers\n\n The bug in question was demonstrated in a discord comment https://discord.com/channels/753336465005608961/1239693193159639073/1239704153400414298 but I don't think we've opened an issue yet. Essentially, because of a mismatch between the outpoint and txout stored in TxGraph, we weren't summing the inputs correctly which caused `calculate_fee` to fail with `NegativeFee` error.\n\n fixes #1419\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### Bugfixes:\n\n * [ ] I've added tests to reproduce the issue which are now passing\n\nACKs for top commit:\n LagginTimes:\n ACK af15ebba94f6d96a4d266fbbdee7c49150f80b96\n evanlinjin:\n ACK af15ebba94f6d96a4d266fbbdee7c49150f80b96\n\nTree-SHA512: c3a2c374069b0863076784856d90c7760b8f411e4881c3e42367015542b02ea6010c37745fb6dde95422af7222b7939ec51bc0fd1f63f816813c2159a17e08e5","shortMessageHtmlLink":"Merge #1443: fix(electrum): Fix fetch_prev_txout"}},{"before":"7876c8fd066ee650043c9ec9691f5a6121152244","after":"7607b4928321d83af96236ec666408ce03e7de70","ref":"refs/heads/master","pushedAt":"2024-05-13T17:25:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1326: chore: rename bdk crate to bdk_wallet\n\nf6781652b7a4833b220e0853cd6e290bb5fc0136 chore: rename bdk crate to bdk_wallet (Steve Myers)\n\nPull request description:\n\n ### Description\n\n Fixes #1305 .\n\n ### Notes to the reviewers\n\n Once this properly builds, even before all reviews is done, I will publish it to crates.io to reserve the name.\n\n ### Changelog notice\n\n Changed\n\n - Renamed `bdk` crate to `bdk_wallet`.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nTop commit has no ACKs.\n\nTree-SHA512: 437c79d9d41721bc9cffd3be81e898068378803dcde6b4106d33bf34ffa756d090dce36d15d4ecd232e5b55ce09c393e6956fc0af4b8477886dabb506b679256","shortMessageHtmlLink":"Merge #1326: chore: rename bdk crate to bdk_wallet"}},{"before":"f17151b00dd06c25382dad787ad3f58d28ee0617","after":null,"ref":"refs/tags/before_1380","pushedAt":"2024-05-10T22:29:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"}},{"before":"63e3bbe8204a600f2525134b1d29628c7012e4f6","after":"7876c8fd066ee650043c9ec9691f5a6121152244","ref":"refs/heads/master","pushedAt":"2024-05-10T22:23:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1437: Bump bdk version to 1.0.0-alpha.11\n\ndb9fdccc18c418cbbdf39ef4e912416796d63860 Bump bdk version to 1.0.0-alpha.11 (Steve Myers)\n\nPull request description:\n\n ### Description\n\n fixes #1435\n\n bdk_chain to 0.14.0\n bdk_bitcoind_rpc to 0.10.0\n bdk_electrum to 0.13.0\n bdk_esplora to 0.13.0\n bdk_file_store to 0.11.0\n bdk_testenv to 0.4.0\n bdk_persist to 0.2.0\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n ValuedMammal:\n ACK db9fdccc18c418cbbdf39ef4e912416796d63860\n storopoli:\n ACK db9fdccc18c418cbbdf39ef4e912416796d63860\n\nTree-SHA512: 804475927461a4bcf37786313123a0a0cc68390af6c556111551dc126a06614296eb657a8a5662a36cf4569ab332f5f9285c99c5f1992d93f43568e881961895","shortMessageHtmlLink":"Merge #1437: Bump bdk version to 1.0.0-alpha.11"}},{"before":"fb7ff298a4bb6254e6d847dbda8bd604552e527e","after":"63e3bbe8204a600f2525134b1d29628c7012e4f6","ref":"refs/heads/master","pushedAt":"2024-05-10T17:33:19.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1403: Update `bdk_electrum` crate to use sync/full-scan structs\n\nb45897e6fe2f7e67f5d75ec6f983757b28c5ec19 feat(electrum): update docs and simplify logic of `ElectrumExt` (志宇)\n92fb6cb37387fb0b9fe5329e772f0d928a33e116 chore(electrum): do not use `anyhow::Result` directly (志宇)\nb2f3cacce6081f3bf6e103d1d2ca0707c545a67e feat(electrum): include option for previous `TxOut`s for fee calculation (Wei Chen)\nc0d7d60a582b939324bb48ec8c5035020ec90699 feat(chain)!: use custom return types for `ElectrumExt` methods (志宇)\n2945c6be88b3bf5105afeb8addff4861f0458b41 fix(electrum): fixed `sync` functionality (Wei Chen)\n9ed33c25ea01278b0a47c8ecd5ea6fa33119a977 docs(electrum): fixed `full_scan`, `sync`, and crate documentation (Wei Chen)\nb1f861b932afd5e490c0814b1921b97cc2f1d912 feat: update logging of electrum examples (志宇)\na6fdfb2ae4caa1cdd23aa5e5ffaf02716473a98e feat(electrum)!: use new sync/full-scan structs for `ElectrumExt` (志宇)\n653e4fed6d16698bc5859c1e4afdcee7b3d83dad feat(wallet): cache txs when constructing full-scan/sync requests (志宇)\n58f27b38eb2093bb9b715b7e0ebd1619ecad74ee feat(chain): introduce `TxCache` to `SyncRequest` and `FullScanRequest` (志宇)\n721bb7f519131ca295a00efa2d242b4923e2bddd fix(chain): Make `Anchor` type in `FullScanResult` generic (志宇)\ne3cfb84898cfa79d4903cf276fc69ffb0605b4d4 feat(chain): `TxGraph::insert_tx` reuses `Arc` (志宇)\n2ffb65618afb7382232a3c08a077dd1109005071 refactor(electrum): remove `RelevantTxids` and track txs in `TxGraph` (Wei Chen)\n\nPull request description:\n\n Fixes #1265\n Possibly fixes #1419\n\n ### Context\n\n Previous changes such as\n\n * Universal structures for full-scan/sync (PR #1413)\n * Making `CheckPoint` linked list query-able (PR #1369)\n * Making `Transaction`s cheaply-clonable (PR #1373)\n\n has allowed us to simplify the interaction between chain-source and receiving-structures (`bdk_chain`).\n\n The motivation is to accomplish something like this ([as mentioned here](https://github.com/bitcoindevkit/bdk/issues/1153#issuecomment-1752263555)):\n ```rust\n let things_I_am_interested_in = wallet.lock().unwrap().start_sync();\n let update = electrum_or_esplora.sync(things_i_am_interested_in)?;\n wallet.lock().unwrap().apply_update(update)?:\n ```\n\n ### Description\n\n This PR greatly simplifies the API of our Electrum chain-source (`bdk_electrum`) by making use of the aforementioned changes. Instead of referring back to the receiving `TxGraph` mid-sync/scan to determine which full transaction to fetch, we provide the Electrum chain-source already-fetched full transactions to start sync/scan (this is cheap, as transactions are wrapped in `Arc`s since #1373).\n\n In addition, an option has been added to include the previous `TxOut` for transactions received from an external wallet for fee calculation.\n\n ### Changelog notice\n\n * Change `TxGraph::insert_tx` to take in anything that satisfies `Into>`. This allows us to reuse the `Arc` pointer of what is being inserted.\n * Add `tx_cache` field to `SyncRequest` and `FullScanRequest`.\n * Make `Anchor` type in `FullScanResult` generic for more flexibility.\n * Change `ElectrumExt` methods to take in `SyncRequest`/`FullScanRequest` and return `SyncResult`/`FullScanResult`. Also update electrum examples accordingly.\n * Add `ElectrumResultExt` trait which allows us to convert the update `TxGraph` of `SyncResult`/`FullScanResult` for `bdk_electrum`.\n * Added an option for `full_scan` and `sync` to also fetch previous `TxOut`s to allow for fee calculation.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n ValuedMammal:\n ACK b45897e6fe2f7e67f5d75ec6f983757b28c5ec19\n notmandatory:\n ACK b45897e6fe2f7e67f5d75ec6f983757b28c5ec19\n\nTree-SHA512: 1e274546015e7c7257965b36079ffe0cb3c2c0b7c2e0c322bcf32a06925a0c3e1119da1c8fd5318f1dbd82c2e952f6a07f227a9b023c48f506a62c93045d96d3","shortMessageHtmlLink":"Merge #1403: Update bdk_electrum crate to use sync/full-scan structs"}},{"before":"86408b90a530b544b42723dc9b74f957b26a5bbd","after":"fb7ff298a4bb6254e6d847dbda8bd604552e527e","ref":"refs/heads/master","pushedAt":"2024-05-09T18:19:05.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1203: Include the descriptor in `keychain::Changeset`\n\n86711d4f46f467c651238ad3804fdbe1d22a8600 doc(chain): add section for non-recommended K to descriptor assignments (Daniela Brozzoni)\nde53d721913537f56281a134270eafd356f908ad test: Only the highest ord keychain is returned (Daniela Brozzoni)\n9d8023bf56a693f1cb2ba340ed024c654307c069 fix(chain): introduce keychain-variant-ranking to `KeychainTxOutIndex` (志宇)\n6c8748124fd40e0fee37f78ca30457441b13fbcb chore(chain): move `use` in `indexed_tx_graph.rs` so clippy is happy (志宇)\n537aa03ae0f8bec4dc799d33738e9bb7977bdac1 chore(chain): update test so clippy does not complain (志宇)\ned117de7a5b1756482b2e6487855b80e97c597ba test(chain): applying changesets one-by-one vs aggregate should be same (志宇)\n6a3fb849e86e0bc21086519ae0201b95ddde5bf4 fix(chain): simplify `Append::append` impl for `keychain::ChangeSet` (志宇)\n1d294b734dd6f4639075cba271e2b40f437f998f fix: Run tests only if the miniscript feature is.. ..enabled, enable it by default (Daniela Brozzoni)\n0e3e136f6fa7215f6391dbcc1c4781262111ce64 doc(bdk): Add instructions for manually inserting... ...secret keys in the wallet in Wallet::load (Daniela Brozzoni)\n76afccc555feff084867d6f9406e4e74bee938cc fix(wallet): add expected descriptors as signers after creating from wallet::ChangeSet (Steve Myers)\n4f05441a00b921efd661da0dff94d9c28e38b70d keychain::ChangeSet includes the descriptor (Daniela Brozzoni)\n8ff99f27dfe45643bf401409ca72429a9b812873 ref(chain): Define test descriptors, use them... ...everywhere (Daniela Brozzoni)\nb9902936a0d17498eec8866233d89b2882d0af8f ref(chain): move `keychain::ChangeSet` into `txout_index.rs` (志宇)\n\nPull request description:\n\n Fixes #1101\n\n - Moves keychain::ChangeSet inside `keychain/txout_index.rs` as now the `ChangeSet` depends on miniscript\n - Slightly cleans up tests by introducing some constant descriptors\n - The KeychainTxOutIndex's internal SpkIterator now uses DescriptorId\n instead of K. The DescriptorId -> K translation is made at the\n KeychainTxOutIndex level.\n - The keychain::Changeset is now a struct, which includes a map for last\n revealed indexes, and one for newly added keychains and their\n descriptor.\n\n ### Changelog notice\n\n API changes in bdk:\n - Wallet::keychains returns a `impl Iterator` instead of `BTreeMap`\n - Wallet::load doesn't take descriptors anymore, since they're stored in the db\n - Wallet::new_or_load checks if the loaded descriptor from db is the same as the provided one\n\n API changes in bdk_chain:\n - `ChangeSet` is now a struct, which includes a map for last revealed\n indexes, and one for keychains and descriptors.\n - `KeychainTxOutIndex::inner` returns a `SpkIterator<(DescriptorId, u32)>`\n - `KeychainTxOutIndex::outpoints` returns a `BTreeSet` instead of `&BTreeSet`\n - `KeychainTxOutIndex::keychains` returns a `impl Iterator` instead of\n `&BTreeMap`\n - `KeychainTxOutIndex::txouts` doesn't return a ExactSizeIterator anymore\n - `KeychainTxOutIndex::last_revealed_indices` returns a `BTreeMap`\n instead of `&BTreeMap`\n - `KeychainTxOutIndex::add_keychain` has been renamed to `KeychainTxOutIndex::insert_descriptor`, and now it returns a ChangeSet\n - `KeychainTxOutIndex::reveal_next_spk` returns Option\n - `KeychainTxOutIndex::next_unused_spk` returns Option\n - `KeychainTxOutIndex::unbounded_spk_iter` returns Option\n - `KeychainTxOutIndex::next_index` returns Option\n - `KeychainTxOutIndex::reveal_to_target` returns Option\n - `KeychainTxOutIndex::revealed_keychain_spks` returns Option\n - `KeychainTxOutIndex::unused_keychain_spks` returns Option\n - `KeychainTxOutIndex::last_revealed_index` returns Option\n - `KeychainTxOutIndex::keychain_outpoints` returns Option\n - `KeychainTxOutIndex::keychain_outpoints_in_range` returns Option\n - `KeychainTxOutIndex::last_used_index` returns None if the keychain has never been used, or if it doesn't exist\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n evanlinjin:\n ACK 86711d4f46f467c651238ad3804fdbe1d22a8600\n\nTree-SHA512: 4b1c9a31951f67b18037b7dd9837acbc35823f21de644ab833754b74d20f5373549f81e66965ecd3953ebf4f99644c9fd834812acfa65f9188950f1bda17ab60","shortMessageHtmlLink":"Merge #1203: Include the descriptor in keychain::Changeset"}},{"before":"66abc73c3dd0e3fb1f18586f6beca2e8d457be83","after":"86408b90a530b544b42723dc9b74f957b26a5bbd","ref":"refs/heads/master","pushedAt":"2024-05-09T00:37:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1430: ci: Pin clippy to rust 1.78.0\n\nde2763a4b88e65b1c67a06148b4f9e012e561c5a ci: Pin clippy to rust 1.78.0 (valued mammal)\n\nPull request description:\n\n This PR pins clippy check in CI to the rust 1.78 toolchain, which prevents new lints in stable releases from interrupting the usual workflow. Because rust versions are released on a predictable schedule, we can revisit this setting in the future as needed (say 3-6 months).\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [ ] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n danielabrozzoni:\n ACK de2763a4b88e65b1c67a06148b4f9e012e561c5a\n storopoli:\n ACK de2763a4b88e65b1c67a06148b4f9e012e561c5a\n notmandatory:\n ACK de2763a4b88e65b1c67a06148b4f9e012e561c5a\n oleonardolima:\n ACK de2763a4b88e65b1c67a06148b4f9e012e561c5a\n\nTree-SHA512: 73cad29a5ff437290aca8f85a011c4f5fc4d9ff5755f3d3ef9fa1820f5631eda857b1a67955adfc6ef98145958c674cc09f7613b96f38cc30c75a656d872edbc","shortMessageHtmlLink":"Merge #1430: ci: Pin clippy to rust 1.78.0"}},{"before":"dcd2d4741d46c30a930b6f673cf12016a65edc54","after":"66abc73c3dd0e3fb1f18586f6beca2e8d457be83","ref":"refs/heads/master","pushedAt":"2024-05-08T00:32:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1423: fix(persist): add default feature to enable bdk_chain/std\n\na577c22b12f4edf0b2f2f266fb13656caf1d21c4 fix(persist): add default feature to enable bdk_chain/std (Steve Myers)\n\nPull request description:\n\n ### Description\n\n This PR adds a `default` feature to `bdk_persist` so it can be build on its own. Once #1422 is done we can remove the `default`again.\n\n ### Notes to the reviewers\n\n I need to be able to build `bdk_persist` on its own so I can publish it to crates.io.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n ValuedMammal:\n ACK a577c22b12f4edf0b2f2f266fb13656caf1d21c4\n oleonardolima:\n ACK a577c22b12f4edf0b2f2f266fb13656caf1d21c4\n storopoli:\n ACK a577c22b12f4edf0b2f2f266fb13656caf1d21c4\n\nTree-SHA512: 8b07a9e4974dec8812ca19ce7226dcaece064270a0be8b83d3c326fdf1e89b051eb0bd8aa0eda9362b2c8233ecd6003b70c92ee046603973d8d40611418c3841","shortMessageHtmlLink":"Merge #1423: fix(persist): add default feature to enable bdk_chain/std"}},{"before":"23538c40390319ca503c0d4b8199eb366051cdd0","after":"dcd2d4741d46c30a930b6f673cf12016a65edc54","ref":"refs/heads/master","pushedAt":"2024-05-06T12:23:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1411: feat: update `keychain::Balance` to use `bitcoin::Amount`\n\n22aa534d7648e5808414ea3adfcfb702572bd6c9 feat: use `Amount` on `TxBuilder::add_recipient` (Leonardo Lima)\nd5c0e7200cba0c3b4d3e3fbea168cd07ee6c1d2c feat: use `Amount` on `spk_txout_index` and related (Leonardo Lima)\n8a33d98db977a07e130ad57fa9c658a5c90d4a4b feat: update `wallet::Balance` to use `bitcoin::Amount` (Leonardo Lima)\n\nPull request description:\n\n fixes #823\n\n \n\n ### Description\n\n It's being used on `Balance`, and throughout the code, an `u64` represents the amount, which relies on the user to infer its sats, not millisats, or any other representation.\n\n It updates the usage of `u64` on `Balance`, and other APIs:\n - `TxParams::add_recipient`\n - `KeyChainTxOutIndex::sent_and_received`, `KeyChainTxOutIndex::net_value`\n - `SpkTxOutIndex::sent_and_received`, `SpkTxOutIndex::net_value`\n\n \n\n ### Notes to the reviewers\n\n \n\n It updates some of the APIs to expect the `bitcoin::Amount`, but it does not update internal usage of u64, such as `TxParams` still expects and uses `u64`, please see the PR comments for related discussion.\n\n ### Changelog notice\n\n \n \n\n - Changed the `keychain::Balance` struct fields to use `Amount` instead of `u64`.\n - Changed the `add_recipient` method on `TxBuilder` implementation to expect `bitcoin::Amount`.\n - Changed the `sent_and_received`, and `net_value` methods on `KeyChainTxOutIndex` to expect `bitcoin::Amount`.\n - Changed the `sent_and_received`, and `net_value` methods on `SpkTxOutIndex` to expect `bitcoin::Amount`.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [x] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n evanlinjin:\n ACK 22aa534d7648e5808414ea3adfcfb702572bd6c9\n\nTree-SHA512: c4e8198d96c0d66cc3d2e4149e8a56bb7565b9cd49ff42113eaebd24b1d7bfeecd7124db0b06524b78b8891ee1bde1546705b80afad408f48495cf3c02446d02","shortMessageHtmlLink":"Merge #1411: feat: update keychain::Balance to use bitcoin::Amount"}},{"before":"a9f737793413e60ad1a96c95a1342a8d839b6991","after":"23538c40390319ca503c0d4b8199eb366051cdd0","ref":"refs/heads/master","pushedAt":"2024-05-06T12:12:33.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1414: chore: clean up `electrsd` and `anyhow` dev dependencies\n\nf6218e4741a4b036d33a9f075ce5feb484e9bd87 chore: reexport crates in `TestEnv` (Wei Chen)\n125959976f63a1e12fc139f048dc2856e993efe5 chore: remove `anyhow` dev dependency from `electrum`, `esplora`, and `bitcoind_rpc` (Wei Chen)\n\nPull request description:\n\n \n\n ### Description\n\n Reexports `electrsd` in `TestEnv` to remove the `electrsd` dev depedency out of `bdk_electrum` and `bdk_esplora`.\n Credit to @ValuedMammal for the idea.\n\n Since `bitcoind` reexports `anyhow`, this dev dependency was also removed from `bdk_electrum`, `bdk_esplora`, and `bdk_bitcoind_rpc`. `bitcoind`, `bitcoincore_rpc` and `electrum_client` were also reexported for convenience.\n\n ### Changelog notice\n\n * Change `bdk_testenv` to re-export internally used crates.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n evanlinjin:\n ACK f6218e4741a4b036d33a9f075ce5feb484e9bd87\n\nTree-SHA512: c7645eb91d08d4ccb80982a992f691b5a8c0df39df506f6b361bc6f2bb076d62cbe5bb5d88b4c684c36e22464c0674f21f6ef4e23733f89b03aa12ec43a67cba","shortMessageHtmlLink":"Merge #1414: chore: clean up electrsd and anyhow dev dependencies"}},{"before":"2703cc6e7806b9edaf83c17737fcc3f43eaafd91","after":"a9f737793413e60ad1a96c95a1342a8d839b6991","ref":"refs/heads/master","pushedAt":"2024-05-06T12:09:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1427: docs(esplora): fixed `full_scan` and `sync` documentation\n\nf6dc6890c37752e80c86c68ae3ca3cc4fac6245e docs(esplora): fixed `full_scan` and `sync` documentation (Wei Chen)\n\nPull request description:\n\n \n\n ### Description\n\n Fixed documentation for `full_scan` and `sync` in `bdk_esplora`.\n\n ### Changelog notice\n\n \n \n * Updated documentation for `full_scan` and `sync` in `bdk_esplora`.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n evanlinjin:\n ACK f6dc6890c37752e80c86c68ae3ca3cc4fac6245e\n storopoli:\n ACK f6dc6890c37752e80c86c68ae3ca3cc4fac6245e\n\nTree-SHA512: 900fb1a2839379af867a6effad32ec4bdfb897330a72ee1e1ec203299e7f3d5fae576550aeed8fd93c5c70a13ad2b0e898033d8b45b490319b5d74216b93f332","shortMessageHtmlLink":"Merge #1427: docs(esplora): fixed full_scan and sync documentation"}},{"before":"fbe17820dc463876e32d0cfff7b3891da37f900d","after":"2703cc6e7806b9edaf83c17737fcc3f43eaafd91","ref":"refs/heads/master","pushedAt":"2024-05-04T12:25:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1417: test(wallet): add thread safety test\n\ndb4734747240d2e1cc72bbfd7be6c49baa8d2967 test(wallet): add thread safety test (Rob N)\n\nPull request description:\n\n ### Description\n\n `Wallet` auto-implements `Send` and `Sync` after removing the generic. This test is a compile time error if there are changes to `Wallet` in the future that make it unsafe to send between threads. See #1387 for discussion.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [ ] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [ ] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [ ] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n evanlinjin:\n ACK db4734747240d2e1cc72bbfd7be6c49baa8d2967\n\nTree-SHA512: 490e666bc503f15286268db7e5e2f75ee44ad2f80251d6f7a01af2a435023b87607eee33623712433ea8d27511be63c6c1e9cad4159b3fe66a4644cfa9e344fb","shortMessageHtmlLink":"Merge #1417: test(wallet): add thread safety test"}},{"before":"b6909e133bf95f9f5c15f4e5b45e7a5c32c0aadf","after":"fbe17820dc463876e32d0cfff7b3891da37f900d","ref":"refs/heads/master","pushedAt":"2024-05-02T15:54:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1420: Bump bdk version to 1.0.0-alpha.10\n\n2cda9f44ee1807898e4f2afffc95774839fee678 Bump bdk version to 1.0.0-alpha.10 (Daniela Brozzoni)\n\nPull request description:\n\n ### Description\n\n bdk_chain to 0.13.0\n bdk_bitcoind_rpc to 0.9.0\n bdk_electrum to 0.12.0\n bdk_esplora to 0.12.0\n bdk_file_store to 0.10.0\n bdk_testenv to 0.3.0\n bdk_persist to 0.2.0\n\n ### Checklists\n #### All Submissions:\n - [x] I've signed all my commits\n - [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n - [x] I ran cargo fmt and cargo clippy before committing\n\nACKs for top commit:\n storopoli:\n ACK 2cda9f44ee1807898e4f2afffc95774839fee678\n\nTree-SHA512: 7d3e5f2c9b9da13713e3bb1e6a11d07e9c381221c837a002aefb780698b1d45d64f2582bd0445ecdf7432bf3fe0ba5d6dadd43aa413cf4e5e557f7334a02fa06","shortMessageHtmlLink":"Merge #1420: Bump bdk version to 1.0.0-alpha.10"}},{"before":"08fac47c2921ffd8d8e1b8d223bc89ae7e94abb1","after":"b6909e133bf95f9f5c15f4e5b45e7a5c32c0aadf","ref":"refs/heads/master","pushedAt":"2024-05-02T13:44:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1421: fix: Cargo clippy lints\n\na5fb7fdf505a53b5865ed83d53745e7efa5e7818 fix: Cargo clippy lints after rust 1.78 (Daniela Brozzoni)\n\nPull request description:\n\n \n\n ### Description\n\n Caught when trying to release (#1420), clippy failed randomly although it worked on master, this happened because rust 1.78 had just been release and we use clippy stable. IMHO we should pin the clippy version in CI and bump it manually at each new rust release.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n notmandatory:\n ACK a5fb7fdf505a53b5865ed83d53745e7efa5e7818\n\nTree-SHA512: c803366367576224f9e9690cdee2c0161fc083550355415f9174e93ada2f597440f54ac966bb3ebecdc916824d43de17ac72801e4ef0f75c8a1df640fe40df6d","shortMessageHtmlLink":"Merge #1421: fix: Cargo clippy lints"}},{"before":"ed3ccc1a9d77e7131954514954a7c001d17734e6","after":"08fac47c2921ffd8d8e1b8d223bc89ae7e94abb1","ref":"refs/heads/master","pushedAt":"2024-05-01T06:59:10.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1413: Introduce universal sync/full-scan structures for spk-based syncing\n\nc0374a0eeb155f1cb4f9d99223f6bc65d24f7df8 feat(chain): `SyncRequest` now uses `ExactSizeIterator`s (志宇)\n0f94f24aaf6374fe2d7c2abf32a870d3849fb8cc feat(esplora)!: update to use new sync/full-scan structures (志宇)\n4c52f3e08e85e73db379ee3411cceb8dbcec92e1 feat(wallet): make wallet compatible with sync/full-scan structures (志宇)\ncdfec5f90726f2313963c3a71e5d18bb10624736 feat(chain): add sync/full-scan structures for spk-based syncing (志宇)\n\nPull request description:\n\n Fixes #1153\n Replaces #1194\n\n ### Description\n\n Introduce universal structures that represent sync/full-scan requests/results.\n\n ### Notes to the reviewers\n\n This is based on #1194 but is different in the following ways:\n * The functionality to print scan/sync progress is not reduced.\n * `SyncRequest` and `FullScanRequest` is simplified and fields are exposed for more flexibility.\n\n ### Changelog notice\n\n * Add universal structures for initiating/receiving sync/full-scan requests/results for spk-based syncing.\n * Updated `bdk_esplora` chain-source to make use of new universal sync/full-scan structures.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n notmandatory:\n tACK c0374a0eeb155f1cb4f9d99223f6bc65d24f7df8\n\nTree-SHA512: c2ad66d972a6785079bca615dfd128edcedf6b7a02670651a0ab1ce5b5174dd96f54644680eedbf55e3f1955fe5c34f632eadbd3f71d7ffde658753c6c6d42be","shortMessageHtmlLink":"Merge #1413: Introduce universal sync/full-scan structures for spk-ba…"}},{"before":"8e73998cfa48d838ab54de0df542b3c2993e65b1","after":"ed3ccc1a9d77e7131954514954a7c001d17734e6","ref":"refs/heads/master","pushedAt":"2024-04-29T08:39:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1412: Add new crate `bdk-persist`\n\n81de8f60516899fad2ec99cbd15d6b8d02385ebb feat(bdk-persist): extract persistence traits to new crate (Rob N)\n\nPull request description:\n\n ### Description\n\n #1387 introduced `anyhow` as a dependency to remove generics from `Wallet`. Introducing a new crate for persistence types removes the dependency on `anyhow` for `bdk_chain`. Resolves #1409, as well as removing the old documentation for \"tracker\".\n\n ### Notes to the reviewers\n\n Open for any comments.\n\n ### Changelog notice\n\n - Introduce `bdk-persist` crate\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [ ] I've added tests for the new feature\n * [ ] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [ ] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n evanlinjin:\n ACK 81de8f60516899fad2ec99cbd15d6b8d02385ebb\n\nTree-SHA512: 29b192b13f3951cc67c06bec7f788d8d7a4aeaf2ffcbf9476d4a6567529d284a93594c8d94b69741a68a9aadfdc9f6c4178084a2298c505e8e0d505219400382","shortMessageHtmlLink":"Merge #1412: Add new crate bdk-persist"}},{"before":"9800f8d88e83b4aee13179f82420412774b7c945","after":"8e73998cfa48d838ab54de0df542b3c2993e65b1","ref":"refs/heads/master","pushedAt":"2024-04-22T09:45:09.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1380: Simplified `EsploraExt` API\n\n96a9aa6e63474dbd93a2ef969eef5b07c79e6491 feat(chain): refactor `merge_chains` (志宇)\n2f22987c9e924800f8682b2dcbdde60fd26b069a chore(chain): fix comment (志宇)\ndaf588f016ec3118c875db8ed6b55fa03683f0f6 feat(chain): optimize `merge_chains` (志宇)\n77d35954c1f3a18f767267e9097f63ca11c709ec feat(chain)!: rm `local_chain::Update` (志宇)\n1269b0610efb7bd86d92a909800f9330568c797a test(chain): fix incorrect test case (志宇)\n72fe65b65f297ebb7160eee6859c46e29c2d9528 feat(esplora)!: simplify chain update logic (志宇)\neded1a7ea0c6a4b9664826df4f77b714cbad0bcc feat(chain): introduce `CheckPoint::insert` (志宇)\n519cd75d23fbb72321b0b189dca12afbfd78c0c7 test(esplora): move esplora tests into src files (志宇)\na6e613e6b978b995abf6c92a16df0300b113aa2c test(esplora): add `test_finalize_chain_update` (志宇)\n494d253493f1bc914adba16a28ccf1bc0a0f4ec8 feat(testenv): add `genesis_hash` method (志宇)\n886d72e3d541d088320bbdad6804057f32aca684 chore(chain)!: rm `missing_heights` and `missing_heights_from` methods (志宇)\nbd62aa0fe199d676710c9909617198d62f4897c0 feat(esplora)!: remove `EsploraExt::update_local_chain` (志宇)\n1e997939837e9c1f0c087d6d28ac12e373c8c05f feat(testenv): add `make_checkpoint_tip` (志宇)\n\nPull request description:\n\n Fixes #1354\n\n ### Description\n\n Built on top of both #1369 and #1373, we simplify the `EsploraExt` API by removing the `update_local_chain` method and having `full_scan` and `sync` update the local chain in the same call. The `full_scan` and `sync` methods now takes in an additional input (`local_tip`) which provides us with the view of the `LocalChain` before the update. These methods now return structs `FullScanUpdate` and `SyncUpdate`.\n\n The examples are updated to use this new API. `TxGraph::missing_heights` and `tx_graph::ChangeSet::missing_heights_from` are no longer needed, therefore they are removed.\n\n Additionally, we used this opportunity to simplify the logic which updates `LocalChain`. We got rid of the `local_chain::Update` struct (which contained the update `CheckPoint` tip and a `bool` which signaled whether we want to introduce blocks below point of agreement). It turns out we can use something like `CheckPoint::insert` so the chain source can craft an update based on the old tip. This way, we can make better use of `merge_chains`' optimization that compares the `Arc` pointers of the local and update chain (before we were crafting the update chain NOT based on top of the previous local chain). With this, we no longer need the `Update::introduce_older_block` field since the logic will naturally break when we reach a matching `Arc` pointer.\n\n ### Notes to the reviewers\n\n * Obtaining the `LocalChain`'s update now happens within `EsploraExt::full_scan` and `EsploraExt::sync`. Creating the `LocalChain` update is now split into two methods (`fetch_latest_blocks` and `chain_update`) that are called before and after fetching transactions and anchors.\n * We need to duplicate code for `bdk_esplora`. One for blocking and one for async.\n\n ### Changelog notice\n\n * Changed `EsploraExt` API so that sync only requires one round of fetching data. The `local_chain_update` method is removed and the `local_tip` parameter is added to the `full_scan` and `sync` methods.\n * Removed `TxGraph::missing_heights` and `tx_graph::ChangeSet::missing_heights_from` methods.\n * Introduced `CheckPoint::insert` which allows convenient checkpoint-insertion. This is intended for use by chain-sources when crafting an update.\n * Refactored `merge_chains` to also return the resultant `CheckPoint` tip.\n * Optimized the update `LocalChain` logic - use the update `CheckPoint` as the new `CheckPoint` tip when possible.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n LLFourn:\n ACK 96a9aa6e63474dbd93a2ef969eef5b07c79e6491\n\nTree-SHA512: 3d4f2eab08a1fe94eb578c594126e99679f72e231680b2edd4bfb018ba1d998ca123b07acb2d19c644d5887fc36b8e42badba91cd09853df421ded04de45bf69","shortMessageHtmlLink":"Merge #1380: Simplified EsploraExt API"}},{"before":"e0bcca32b1f9e9d3f198cc59ab12d2d856307dd0","after":"9800f8d88e83b4aee13179f82420412774b7c945","ref":"refs/heads/master","pushedAt":"2024-04-20T08:01:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1408: Fix: enable blocking-https-rustls feature on esplora client\n\nd3a14d411d2a1a37f07e42c28eae3a1836aec14d fix: enable blocking-https-rustls feature on esplora client (thunderbiscuit)\n\nPull request description:\n\n The [`blocking` feature on the rust-esplora-client library](https://github.com/bitcoindevkit/rust-esplora-client/blame/master/Cargo.toml#L35) changed from ureq to minreq, which does not come with https enabled by default, breaking previously working code that simply enabled the `blocking` feature on the `bdk_esplora` crate.\n\n This change will enable what is currently the \"default https\" [flag for the minreq library](https://docs.rs/minreq/latest/minreq/#https-or-https-rustls) when using the `blocking` feature on bdk_esplora, reverting that breaking change.\n\n ### Notes to the reviewers\n\n Another way we could do this (let me know if this is preferable) is to add a new feature called `blocking-https-rustls`:\n ```rust\n blocking = [\"esplora-client/blocking\"]\n blocking-https-rustls = [\"esplora-client/blocking-https-rustls\"]\n ```\n\n ### Changelog notice\n \n \n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [ ] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [ ] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n storopoli:\n ACK d3a14d411d2a1a37f07e42c28eae3a1836aec14d\n evanlinjin:\n ACK d3a14d411d2a1a37f07e42c28eae3a1836aec14d\n\nTree-SHA512: d25495186ceba2fcd04bc9ff0aebfb32ac5db6885ef8e4df1e304c5ee5264f6161821e06d29367d2837afcc64a53f1553e7c0bb065e6a2e46dc08b8e04c2ad8e","shortMessageHtmlLink":"Merge #1408: Fix: enable blocking-https-rustls feature on esplora client"}},{"before":"f00de9e0c192683c30298bcebfdeda6b7c2214d3","after":"e0bcca32b1f9e9d3f198cc59ab12d2d856307dd0","ref":"refs/heads/master","pushedAt":"2024-04-20T07:42:33.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1402: [wallet] Improve address API\n\nd39b319ddf6bf3365d5d01841a8d366c6231db06 test(wallet): Test wallet addresses (valued mammal)\na266b4718f7839759a3e615805931041b67b8e91 chore(wallet)!: Remove enum AddressIndex (valued mammal)\nd87874780b4a4c7be282381ae1102c028f3ae581 refactor(wallet)!: Remove method get_address (valued mammal)\nd3763e5e37569cea0860217fba980ab0389e4e64 feat(wallet): Add new address methods (valued mammal)\n\nPull request description:\n\n Improvements to the wallet address API, see commit messages for details.\n\n ### Notes to the reviewers\n\n The logic of getting addresses is roughly the same as before when using `AddressIndex`, following this mapping:\n\n - `New` -> `reveal_next_address`\n - `LastUnused` -> `next_unused_address` (assuming this is what `LastUnused` really means)\n - `Peek` -> `peek_address`\n\n Wondering whether it makes sense to expose [`is_used`](https://github.com/bitcoindevkit/bdk/blob/358e842dcda0eb867d229881823c76dba1d7cce1/crates/chain/src/keychain/txout_index.rs#L236) for Wallet as well.\n\n fixes #898\n\n ### Changelog notice\n\n Added:\n\n - Added Wallet methods:\n - `peek_address`\n - `reveal_next_address`\n - `next_unused_address`\n - `reveal_addresses_to`\n - `list_unused_addresses`\n - `mark_used`\n - `unmark_used`\n\n Removed:\n\n - Removed Wallet methods:\n - `get_address`\n - `get_internal_address`\n - `try_get_address`\n - `try_get_internal_address`\n\n - Removed type AddressIndex\n\n ### Checklists\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n ### Feature\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n * [x] This pull request breaks the existing API\n * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n evanlinjin:\n ACK d39b319ddf6bf3365d5d01841a8d366c6231db06\n\nTree-SHA512: ab7f3031f552ee6ea58ae4f3c5412bbedc0ea63e662fe9fa402de0f68a50448521be1e118e89f70bf970d5bf44ea1dc66bbeeff3e9312bae966bebd3072a7073","shortMessageHtmlLink":"Merge #1402: [wallet] Improve address API"}},{"before":"52f395555792a2f24ae7248d98da318bdad5dadb","after":"f00de9e0c192683c30298bcebfdeda6b7c2214d3","ref":"refs/heads/master","pushedAt":"2024-04-20T06:54:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1387: fix(wallet): remove the generic from wallet\n\ne51af49ffa951e14203ac2b465ade351dd90f6cd fix(wallet): remove generic from wallet (Rob N)\n\nPull request description:\n\n ### Description\n\n The `PersistenceBackend` uses generics to describe errors returned while applying the change set to the persistence layer. This change removes generics wherever possible and introduces a new public error enum. Removing the generics from `PersistenceBackend` errors is the first step towards #1363\n\n *Update*: I proceeded with removing the generics from `Wallet` by introducing a `Box` .\n\n ### Notes to the reviewers\n\n This one sort of blew up in the number of changes due to the use of generics for most of the `Wallet` error variants. The generics were only used for the persistence errors, so I removed the generics from higher level errors whenever possible. The error variants of `PersistenceBackend` may also be more expressive, but I will level that up for discussion and make any changes required.\n\n ### Changelog notice\n\n - Changed `PersistenceBackend` errors to depend on the `anyhow` crate.\n - Remove the generic `T` from `Wallet`\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [ ] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\n #### Bugfixes:\n\n * [x] This pull request breaks the existing API\n * [ ] I've added tests to reproduce the issue which are now passing\n * [x] I'm linking the issue being fixed by this PR\n\nACKs for top commit:\n evanlinjin:\n ACK e51af49ffa951e14203ac2b465ade351dd90f6cd\n\nTree-SHA512: 8ce4f1c495310e16145555f4a6a29a0f42cf8944eda68004595c3532580767f64f779185022147a00d75001c40d69fdf8f8de2d348eb68484b170d2a181117ff","shortMessageHtmlLink":"Merge #1387: fix(wallet): remove the generic from wallet"}},{"before":"ee21ffeee092763f67e4b78583b06966ed7ee4e7","after":"52f395555792a2f24ae7248d98da318bdad5dadb","ref":"refs/heads/master","pushedAt":"2024-04-18T07:39:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1324: [chain] Make KeychainTxOutIndex more range based\n\nfac228337c79e1a7c406500c177e049e7f9f5da7 feat(chain)!: make `KeychainTxOutIndex` more range based (LLFourn)\n\nPull request description:\n\n KeychainTxOut index should try and avoid \"all\" kind of queries. There may be subranges of interest. If the user wants \"all\" they can just query \"..\".\n\n The ideas is that KeychainTxOutIndex should be designed to be able to incorporate many unrelated keychains that can be managed in the same index. We should be able to see the \"net_value\" of a transaction to a specific subrange. e.g. imagine a collaborative custody service that manages all their user descriptors inside the same `KeychainTxOutIndex`. One user in their service may pay another so when you are analyzing how much a transaction is spending for a particular user you need to do analyze a particular sub-range.\n\n ### Notes to the reviewers\n\n - I didn't change `unused_spks` to follow this rule because I want to delete that method some time in the future. `unused_spks` is being used in the examples for syncing but it shouldn't be (the discussion as to why will probably surface in #1194).\n - I haven't applied this reasoning to the methods that return `BTreeMap`s e.g. `all_unbounded_spk_iters`. It probably should be but I haven't made up my mind yet.\n\n This probably belongs after #1194\n\n ### Changelog notice\n\n - `KeychainTxOutIndex` methods modified to take ranges of keychains instead.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nACKs for top commit:\n evanlinjin:\n ACK fac228337c79e1a7c406500c177e049e7f9f5da7\n\nTree-SHA512: ec1e75f19d79f71de4b6d7748ef6da076ca92c2f3fd07e0f0dc88e091bf80c61268880ef78be4bed5e0dbab2572e22028f868f33e68a67d47813195d38d78ba5","shortMessageHtmlLink":"Merge #1324: [chain] Make KeychainTxOutIndex more range based"}},{"before":"f17151b00dd06c25382dad787ad3f58d28ee0617","after":null,"ref":"refs/tags/before_1380","pushedAt":"2024-04-15T20:40:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"}},{"before":"358e842dcda0eb867d229881823c76dba1d7cce1","after":"ee21ffeee092763f67e4b78583b06966ed7ee4e7","ref":"refs/heads/master","pushedAt":"2024-04-15T20:10:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1404: Bump bdk version to 1.0.0-alpha.9\n\n5f238d8e672047ac2766550aa3ed97e05e7b2531 Bump bdk version to 1.0.0-alpha.9 (Steve Myers)\n\nPull request description:\n\n ### Description\n\n Bump bdk version to 1.0.0-alpha.9\n\n bdk_chain to 0.12.0\n bdk_bitcoind_rpc to 0.8.0\n bdk_electrum to 0.11.0\n bdk_esplora to 0.11.0\n bdk_file_store to 0.9.0\n bdk_testenv to 0.2.0\n\n fixes #1399\n\n ### Notes to the reviewers\n\n I also removed unneeded version for bdk_testenv in dev-dependencies, see https://github.com/bitcoindevkit/bdk/pull/1177#discussion_r1545945973.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n evanlinjin:\n ACK 5f238d8e672047ac2766550aa3ed97e05e7b2531\n\nTree-SHA512: 7ede94a6476a6b8c49a16b0aad147030eab23e26b9c4cadb1dd319fb8562ae325640f506f2d6dab0e85b0ee7f6955ac298ec1f70264704dc7f9a9492f8794f38","shortMessageHtmlLink":"Merge #1404: Bump bdk version to 1.0.0-alpha.9"}},{"before":"c7f87b50e46887e92affb0685e2a98364a68456d","after":"358e842dcda0eb867d229881823c76dba1d7cce1","ref":"refs/heads/master","pushedAt":"2024-04-12T16:02:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1177: Upgrade bitcoin/miniscript dependencies\n\n984c758f964f8fee687d21885b43b0b4705f318c Upgrade miniscript/bitcoin dependency (Tobin C. Harding)\n\nPull request description:\n\n Upgrade:\n\n - bitcoin to v0.31.0\n - miniscript to v11.0.0\n\n Fix: #1196\n\nACKs for top commit:\n ValuedMammal:\n ACK 984c758f964f8fee687d21885b43b0b4705f318c\n notmandatory:\n ACK 984c758f964f8fee687d21885b43b0b4705f318c\n oleonardolima:\n ACK 984c758f964f8fee687d21885b43b0b4705f318c\n storopoli:\n ACK 984c758f964f8fee687d21885b43b0b4705f318c\n\nTree-SHA512: d64d530e93cc36688ba07d3677d5c1689b61f246f05d08092bbf86ddbba8a5ec49648e6825b950ef17729dc064da50d50b793475a288862a0461976876807170","shortMessageHtmlLink":"Merge #1177: Upgrade bitcoin/miniscript dependencies"}},{"before":"62619d3a4a644b584215ad99bad1c65d20cf0fe7","after":"c7f87b50e46887e92affb0685e2a98364a68456d","ref":"refs/heads/master","pushedAt":"2024-04-12T05:29:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1397: Introduce proptesting, starting with `CheckPoint::range`\n\n446b045161ebad3fbdf0ea96e8ff6f9da8ad212c test(chain): introduce proptest for `CheckPoint::range` (志宇)\n\nPull request description:\n\n ### Description\n\n This is based on #1369. It made sense for me to introduce the `CheckPoint::range` test as a proptest. I think we should also start introducing it for other methods too.\n\n ### Changelog notice\n\n * Added proptest for `CheckPoint::range`.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\n #### New Features:\n\n * [x] I've added tests for the new feature\n * [x] I've added docs for the new feature\n\nTop commit has no ACKs.\n\nTree-SHA512: 2d8aad5a1ad152413fbc716fed4a47ad621e723928c5331728da2fbade995ebd677acfa05d2e7639d74d0f66e0971c72582d9cd562ea008b012774057b480d62","shortMessageHtmlLink":"Merge #1397: Introduce proptesting, starting with CheckPoint::range"}},{"before":"53791eb6c5352d9bc7c8ed1cc3062e48f5a5116c","after":"62619d3a4a644b584215ad99bad1c65d20cf0fe7","ref":"refs/heads/master","pushedAt":"2024-04-11T13:33:27.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"evanlinjin","name":"志宇","path":"/evanlinjin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14065705?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/bdk#1385: Fix last seen unconfirmed\n\na2a64ffb6e92baf46a912f36294f3f4f521a528a fix(electrum)!: Remove `seen_at` param from `into_tx_graph` (valued mammal)\n37fca35ddede6cbc9d9428a2722eff82a405b1b2 feat(tx_graph): Add method update_last_seen_unconfirmed (valued mammal)\n\nPull request description:\n\n A method `update_last_seen_unconfirmed` is added for `TxGraph` that allows inserting a `seen_at` time for all unanchored transactions.\n\n fixes #1336\n\n ### Changelog notice\n\n Changed:\n - Methods `into_tx_graph` and `into_confirmation_time_tx_graph`for `RelevantTxids` are changed to no longer accept a `seen_at` parameter.\n\n Added:\n - Added method `update_last_seen_unconfirmed` for `TxGraph`.\n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n evanlinjin:\n ACK a2a64ffb6e92baf46a912f36294f3f4f521a528a\n\nTree-SHA512: 9011e63314b0e3ffcd50dbf5024f82b365bab1cc834c0455d7410b682338339ed5284caa721ffc267c65fa26d35ff6ee86cde6052e82a6a79768547fbb7a45eb","shortMessageHtmlLink":"Merge #1385: Fix last seen unconfirmed"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUoBxDwA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoindevkit/bdk"}