Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird focus rect displayed on inital sync #783

Open
1 task done
ManuelSchneid3r opened this issue Dec 20, 2023 · 4 comments · May be fixed by #795
Open
1 task done

Weird focus rect displayed on inital sync #783

ManuelSchneid3r opened this issue Dec 20, 2023 · 4 comments · May be fixed by #795
Labels
Bug Something isn't working

Comments

@ManuelSchneid3r
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

Bildschirmfoto 2023-12-20 um 11 41 09

Expected behaviour

Bildschirmfoto 2023-12-20 um 11 43 55

Steps to reproduce

Start Bitcoin-Qt

Relevant log output

No response

How did you obtain Bitcoin Core

Pre-built binaries

What version of Bitcoin Core are you using?

Bitcoin Core Version v25.0.0

Operating system and version

mac 13.6 (22G120)

Machine specifications

No response
@ManuelSchneid3r
Copy link
Author

Just updated to 26. still there.

@jadijadi
Copy link
Contributor

jadijadi commented Feb 9, 2024

Tried to reproduce this on 26.9.9 with no successful.
May I ask how you produced the "expected result" image? what do you do to "fix" the issue? And is there a way to "show/hide" the strange rectangular? I can see that in the problematic photo you have the Hide button focused too. Does losing the focus hides the strange highlight square?

@ManuelSchneid3r
Copy link
Author

ManuelSchneid3r commented Feb 9, 2024 •
edited

I just started it. yes Actually I deactivated the app to let the focus disappear, which is expected behavior. I just used it to take a screenie.

@jadijadi
Copy link
Contributor

jadijadi commented Feb 14, 2024 •
edited

Thanks for the explanation. I'm able to reproduce and will work on it today.

jadijadi added a commit to jadijadi/bitcoin-core-gui that referenced this issue Feb 14, 2024
@jadijadi
qt: prevent weird focus rect on inital sync
e6418e6 
During the initial sync, the Tab moves the focus to the widgets
of the main window, even when the ModalOverlay is visible. This
creates some weird rectangular *selections on the screen*.

This PR fixes this by keeping the focus on the "Hide" button while
the ModalOverlay is visible.

Fixes bitcoin-core#783
@jadijadi jadijadi linked a pull request Feb 14, 2024 that will close this issue
Open
@hebasto hebasto added the Bug Something isn't working label Feb 15, 2024
jadijadi added a commit to jadijadi/bitcoin-core-gui that referenced this issue Feb 15, 2024
@jadijadi
qt: keep focus on "Hide" while ModalOverlay is visible
1b34e0d 
During the initial sync, the Tab moves the focus to the widgets
of the main window, even when the ModalOverlay is visible. This
creates some weird rectangular *selections on the screen*.

This PR fixes this by keeping the focus on the "Hide" button while
the ModalOverlay is visible.

Fixes bitcoin-core#783
jadijadi added a commit to jadijadi/bitcoin-core-gui that referenced this issue Feb 17, 2024
@jadijadi
qt: keep focus on "Hide" while ModalOverlay is visible
992b1bb 
During the initial sync, the Tab moves the focus to the widgets
of the main window, even when the ModalOverlay is visible. This
creates some weird rectangular *selections on the screen*.

This PR fixes this by keeping the focus on the "Hide" button while
the ModalOverlay is visible.

Fixes bitcoin-core#783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep focus on "Hide" while ModalOverlay is visible jadijadi/bitcoin-core-gui
3 participants
@jadijadi @ManuelSchneid3r @hebasto